From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01990A046B for <public@inbox.dpdk.org>; Thu, 27 Jun 2019 14:39:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CAC3D4F91; Thu, 27 Jun 2019 14:39:32 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 80B1A2BA5 for <dev@dpdk.org>; Thu, 27 Jun 2019 14:39:30 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2019 05:39:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,423,1557212400"; d="scan'208";a="173112147" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga002.jf.intel.com with ESMTP; 27 Jun 2019 05:39:28 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by irsmsx105.ger.corp.intel.com (163.33.3.28) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Jun 2019 13:39:27 +0100 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.143]) by irsmsx112.ger.corp.intel.com ([10.108.20.5]) with mapi id 14.03.0439.000; Thu, 27 Jun 2019 13:39:27 +0100 From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com> To: "Richardson, Bruce" <bruce.richardson@intel.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "Richardson, Bruce" <bruce.richardson@intel.com> Thread-Topic: [dpdk-dev] [PATCH 0/4] Enhance CPU flag support Thread-Index: AQHVFjUSCLX63LvvMUylNFGQpeud8qavng0w Date: Thu, 27 Jun 2019 12:39:26 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725801689E601A@IRSMSX104.ger.corp.intel.com> References: <20190529154132.49955-1-bruce.richardson@intel.com> In-Reply-To: <20190529154132.49955-1-bruce.richardson@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDVjNjc2OTUtNzBkNS00OTRhLWI3OWUtNzU0YzEzMmQwMzRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQ2M5enVuUGRSZnRKYWdBWVVXTk85UE1QbmFKM1JHWjFjZmlWZEVUSkRaQWVZS3lpN2tSZ0VubGNINXVFXC9aeDcifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/4] Enhance CPU flag support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, May 29, 2019 4:41 PM > To: dev@dpdk.org > Cc: Richardson, Bruce <bruce.richardson@intel.com> > Subject: [dpdk-dev] [PATCH 0/4] Enhance CPU flag support >=20 > Currently in DPDK, any checks for the presence or absense of specific > CPU flags has to be enclosed in #ifdef blocks, since the flags are > conditionally defined per architecture as enums. This set attempts to > improve this situation by allowing the flags to be queried as strings, > with a CPU architecture type also specified. One new public API is > provided for this. [Other APIs used by that are internal for now, but > have an rte_ prefix in case we want to expose them publically later] >=20 > To test out this new functionality the crc code in the net library is > updated to use this, demonstrating how the code can be simplified and > the use of #ifdef's reduced. >=20 > Bruce Richardson (4): > build: fix quoting on RTE_ARCH string value > config/arm: fix missing define for arm platforms > eal: allow checking CPU flags by name > net: replace ifdefs with runtime branches >=20 > config/arm/meson.build | 2 + > config/ppc_64/meson.build | 2 +- > config/x86/meson.build | 4 +- > lib/librte_eal/common/eal_common_cpuflags.c | 41 +++++++++++++++++ > .../common/include/generic/rte_cpuflags.h | 44 ++++++++++++++++++- > lib/librte_eal/rte_eal_version.map | 3 ++ > lib/librte_net/rte_net_crc.c | 38 ++++++++++------ > 7 files changed, 117 insertions(+), 17 deletions(-) >=20 > -- Series Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> > 2.21.0