Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: add parameter --mtu parse option

["Ananyev, Konstantin" <konstantin.ananyev@intel.com>]

Hi guys,

> 
> Hi Tao
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of
> > taox.zhu@intel.com
> > Sent: Thursday, July 18, 2019 3:22 PM
> > To: Nicolau, Radu <radu.nicolau@intel.com>; akhil.goyal@nxp.com
> > Cc: dev@dpdk.org; Zhu, TaoX <taox.zhu@intel.com>
> > Subject: [dpdk-dev] [PATCH] examples/ipsec-secgw: add parameter --mtu
> > parse option
> >
> > From: Zhu Tao <taox.zhu@intel.com>
> >
> > This patch add parameter --mtu parse key and enumeration value.
> >
> > Signed-off-by: Zhu Tao <taox.zhu@intel.com>
> > ---
> >  examples/ipsec-secgw/ipsec-secgw.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-
> > secgw/ipsec-secgw.c
> > index b1ecbb975..05fffa967 100644
> > --- a/examples/ipsec-secgw/ipsec-secgw.c
> > +++ b/examples/ipsec-secgw/ipsec-secgw.c
> > @@ -159,6 +159,7 @@ static const struct option lgopts[] = {
> >  	{CMD_LINE_OPT_RX_OFFLOAD, 1, 0,
> > CMD_LINE_OPT_RX_OFFLOAD_NUM},
> >  	{CMD_LINE_OPT_TX_OFFLOAD, 1, 0,
> > CMD_LINE_OPT_TX_OFFLOAD_NUM},
> >  	{CMD_LINE_OPT_REASSEMBLE, 1, 0,
> > CMD_LINE_OPT_REASSEMBLE_NUM},
> > +	{CMD_LINE_OPT_MTU, 1, 0, CMD_LINE_OPT_MTU_NUM},
> >  	{NULL, 0, 0, 0}
> >  };
> >
> > --
> > 2.17.1

Thanks for fixing it for me, don't know where I lost that line.

> 
> This patch looks like a fix, if so it should have a fixes line and Cc: stable@dpdk.org if it is to be back ported.

I am agree with Bernard about fixes line, though no need to CC stable,
as this bug was introduced in 19.08 timeframe.

> 
> Also
> ./devtools/check-git-log.sh -1
> Wrong headline lowercase:
>         examples/ipsec-secgw: add parameter --mtu parse option
> 

Apart from the nits mentioned above:
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Tested-by: Konstantin Ananyev <konstantin.ananyev@intel.com>