From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7490BA0471 for ; Thu, 18 Jul 2019 12:58:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7519F1DBE; Thu, 18 Jul 2019 12:58:54 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id D44B01041 for ; Thu, 18 Jul 2019 12:58:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2019 03:58:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,278,1559545200"; d="scan'208";a="343333711" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga005.jf.intel.com with ESMTP; 18 Jul 2019 03:58:50 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 18 Jul 2019 11:58:49 +0100 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.164]) by irsmsx111.ger.corp.intel.com ([169.254.2.65]) with mapi id 14.03.0439.000; Thu, 18 Jul 2019 11:58:49 +0100 From: "Ananyev, Konstantin" To: "Iremonger, Bernard" , "Zhu, TaoX" , "Nicolau, Radu" , "akhil.goyal@nxp.com" CC: "dev@dpdk.org" , "Zhu, TaoX" Thread-Topic: [dpdk-dev] [PATCH] examples/ipsec-secgw: add parameter --mtu parse option Thread-Index: AQHVPSxKj3IptiFC8U6MvDHzkJEjQabQDkWAgAAlm9A= Date: Thu, 18 Jul 2019 10:58:48 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772580168A56F59@irsmsx105.ger.corp.intel.com> References: <20190718142143.7148-1-taox.zhu@intel.com> <8CEF83825BEC744B83065625E567D7C260DD1866@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260DD1866@IRSMSX108.ger.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDQ5NGNlZTYtYjQ1Yi00NGM2LTk4YWEtOTI4MmVmZmY5NTQ5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibDk2aVBGbTdkT3lLZnl1MEt1K2lMbUdwVWlOckNsSlYxUFR6ZTVNbWVoUDNiTjVzd1ZIZFdcL2lOQTlUWlRBSmYifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: add parameter --mtu parse option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi guys, >=20 > Hi Tao >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of > > taox.zhu@intel.com > > Sent: Thursday, July 18, 2019 3:22 PM > > To: Nicolau, Radu ; akhil.goyal@nxp.com > > Cc: dev@dpdk.org; Zhu, TaoX > > Subject: [dpdk-dev] [PATCH] examples/ipsec-secgw: add parameter --mtu > > parse option > > > > From: Zhu Tao > > > > This patch add parameter --mtu parse key and enumeration value. > > > > Signed-off-by: Zhu Tao > > --- > > examples/ipsec-secgw/ipsec-secgw.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec- > > secgw/ipsec-secgw.c > > index b1ecbb975..05fffa967 100644 > > --- a/examples/ipsec-secgw/ipsec-secgw.c > > +++ b/examples/ipsec-secgw/ipsec-secgw.c > > @@ -159,6 +159,7 @@ static const struct option lgopts[] =3D { > > {CMD_LINE_OPT_RX_OFFLOAD, 1, 0, > > CMD_LINE_OPT_RX_OFFLOAD_NUM}, > > {CMD_LINE_OPT_TX_OFFLOAD, 1, 0, > > CMD_LINE_OPT_TX_OFFLOAD_NUM}, > > {CMD_LINE_OPT_REASSEMBLE, 1, 0, > > CMD_LINE_OPT_REASSEMBLE_NUM}, > > + {CMD_LINE_OPT_MTU, 1, 0, CMD_LINE_OPT_MTU_NUM}, > > {NULL, 0, 0, 0} > > }; > > > > -- > > 2.17.1 Thanks for fixing it for me, don't know where I lost that line. >=20 > This patch looks like a fix, if so it should have a fixes line and Cc: st= able@dpdk.org if it is to be back ported. I am agree with Bernard about fixes line, though no need to CC stable, as this bug was introduced in 19.08 timeframe. >=20 > Also > ./devtools/check-git-log.sh -1 > Wrong headline lowercase: > examples/ipsec-secgw: add parameter --mtu parse option >=20 Apart from the nits mentioned above: Acked-by: Konstantin Ananyev Tested-by: Konstantin Ananyev