From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3312DA00E6 for ; Tue, 6 Aug 2019 17:59:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C34211B502; Tue, 6 Aug 2019 17:59:01 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 8655F2BCE for ; Tue, 6 Aug 2019 17:59:00 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Aug 2019 08:58:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,353,1559545200"; d="scan'208";a="198351794" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga004.fm.intel.com with ESMTP; 06 Aug 2019 08:58:57 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by irsmsx110.ger.corp.intel.com (163.33.3.25) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 6 Aug 2019 16:58:56 +0100 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.164]) by IRSMSX156.ger.corp.intel.com ([169.254.3.73]) with mapi id 14.03.0439.000; Tue, 6 Aug 2019 16:58:56 +0100 From: "Ananyev, Konstantin" To: Matan Azrad , "dev@dpdk.org" CC: Thomas Monjalon , "Yigit, Ferruh" , Andrew Rybchenko , Olivier Matz Thread-Topic: [PATCH 2/2] doc: announce new mbuf field for LRO Thread-Index: AQHVTGc16KeOU/cz2kOGn4+V+To/WqbuRh+g Date: Tue, 6 Aug 2019 15:58:56 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772580168A62AC0@irsmsx105.ger.corp.intel.com> References: <1565103383-23864-1-git-send-email-matan@mellanox.com> <1565103383-23864-2-git-send-email-matan@mellanox.com> In-Reply-To: <1565103383-23864-2-git-send-email-matan@mellanox.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzk3YWNjMzQtYjg5YS00ZGM0LTg2MzQtMjRjZDk0YjZiNzY5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUEdTSGdjUDdiTWpkd1pONm92V09ZWlFEaGlXMHhqclZ1QTI0YWtFSXVwTmZlXC91eVRUaGc5akN3eGRqSGZWN1MifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] doc: announce new mbuf field for LRO X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Matan Azrad [mailto:matan@mellanox.com] > Sent: Tuesday, August 6, 2019 3:56 PM > To: dev@dpdk.org > Cc: Thomas Monjalon ; Yigit, Ferruh ; Andrew Rybchenko ; > Ananyev, Konstantin ; Olivier Matz > Subject: [PATCH 2/2] doc: announce new mbuf field for LRO >=20 > The API breakage is because the ``tso_segsz`` field was documented for > LRO. >=20 > The ``tso_segsz`` field in mbuf indicates the size of each segment in > the LRO packet in Rx path and should be provided by the LRO packet > port. >=20 > While the generic LRO packet may aggregate different segments sizes in > one packet, it is impossible to expose this information for each segment > by one field and it doesn't make sense to expose all the segments sizes > in the mbuf. >=20 > A new field may be added as union with the above field to expose the > number of segments aggregated in the LRO packet. >=20 > Signed-off-by: Matan Azrad > --- > doc/guides/rel_notes/deprecation.rst | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/= deprecation.rst > index c0cd9bc..e826b69 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -45,6 +45,10 @@ Deprecation Notices > - ``eal_parse_pci_DomBDF`` replaced by ``rte_pci_addr_parse`` > - ``rte_eal_compare_pci_addr`` replaced by ``rte_pci_addr_cmp`` >=20 > +* mbuf: Remove ``tso_segsz`` mbuf field providing for LRO support. Use u= nion > + block for the field memory to be shared with a new field ``lro_segs_n`= ` > + indicates the number of segments aggregated in the LRO packet. > + Wonder how the upper layer will use that information (except for stats)? Could you guys provide any examples? Also what PMD should do if HW does supports LRO, but doesn't provide that i= nformation?=20 Konstantin =20 > * dpaa2: removal of ``rte_dpaa2_memsegs`` structure which has been repla= ced > by a pa-va search library. This structure was earlier being used for h= olding > memory segments used by dpaa2 driver for faster pa->va translation. Th= is > -- > 1.8.3.1