From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78D24A00E6 for ; Fri, 9 Aug 2019 10:47:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3CBBF3DC; Fri, 9 Aug 2019 10:47:11 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 57838271 for ; Fri, 9 Aug 2019 10:47:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Aug 2019 01:47:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,364,1559545200"; d="scan'208";a="350438453" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga005.jf.intel.com with ESMTP; 09 Aug 2019 01:47:05 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.164]) by IRSMSX153.ger.corp.intel.com ([169.254.9.99]) with mapi id 14.03.0439.000; Fri, 9 Aug 2019 09:47:04 +0100 From: "Ananyev, Konstantin" To: "pbhagavatula@marvell.com" , "jerinj@marvell.com" , "stephen@networkplumber.org" , "arybchenko@solarflare.com" , "hemant.agrawal@nxp.com" , "thomas@monjalon.net" , "Yigit, Ferruh" , "Richardson, Bruce" , Neil Horman , "Mcnamara, John" , "Kovacevic, Marko" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [patch v4] doc: announce API change in ethdev offload flags Thread-Index: AQHVTor4Jnh7ofmOA0Wc6hScRJQNZKbyf47g Date: Fri, 9 Aug 2019 08:47:03 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772580168A64124@irsmsx105.ger.corp.intel.com> References: <20190808085859.796-1-pbhagavatula@marvell.com> <20190809081740.1607-1-pbhagavatula@marvell.com> In-Reply-To: <20190809081740.1607-1-pbhagavatula@marvell.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGYwYzY1NzQtNDZhZS00YjYzLThkOTEtODczYmQwMjk1MjBkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWnFnaWhsTWR0OUpDdTZNNXo4QTQ0UkwzVGVEamlseVpNV2lDanJRZHliOUtLdjNOb2Fka1wvRWZueW9haXBOTVgifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [patch v4] doc: announce API change in ethdev offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi=20 >=20 > From: Pavan Nikhilesh >=20 > Add new offload flags ``DEV_RX_OFFLOAD_RSS`` and ``DEV_RX_OFFLOAD_FLOW_MA= RK``. > Add new function ``rte_eth_dev_set_supported_ptypes`` to allow applicatio= n to > set specific ptypes to be updated in ``rte_mbuf::packet_type`` >=20 > Signed-off-by: Pavan Nikhilesh > Acked-by: Andrew Rybchenko > Acked-by: Jerin Jacob > Acked-by: Hemant Agrawal > --- > doc/guides/rel_notes/deprecation.rst | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) >=20 > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/= deprecation.rst > index 37b8592b6..e4e2a85d7 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -78,3 +78,26 @@ Deprecation Notices > to set new power environment if power environment was already initiali= zed. > In this case the function will return -1 unless the environment is uns= et first > (using ``rte_power_unset_env``). Other function usage scenarios will n= ot change. > + > +* ethdev: New offload flags ``DEV_RX_OFFLOAD_RSS_HASH`` and ``DEV_RX_OFF= LOAD_FLOW_MARK`` > + will be added in 19.11. > + This will allow application to enable or disable PMDs from updating > + ``rte_mbuf::hash::rss`` and ``rte_mbuf::hash::fdir`` respectively. > + This scheme will allow PMDs to avoid writes to ``rte_mbuf`` fields on = Rx and > + thereby improve Rx performance if application wishes do so. > + In 19.11 PMDs will still update the fields even when the offloads are = not > + enabled. > + > +* ethdev: New function ``rte_eth_dev_set_supported_ptypes`` will be adde= d in > + 19.11. As I said in my previous mail, I do support the idea, though few nits below= . > + This will allow application to request PMD to set specific ptypes defi= ned > + through ``rte_eth_dev_set_supported_ptypes`` in ``rte_mbuf::packet_typ= e``. > + If application doesn't want any ptype information it can call > + ``rte_eth_dev_set_supported_ptypes(ethdev_id, RTE_PTYPE_UNKNOWN)`` Probably worth to mention that in that case packet_type will be set to 0 (PMD still need to set the value). > + If application doesn't call ``rte_eth_dev_set_supported_ptypes`` PMD c= an > + return ``rte_mbuf::packet_type`` with ``rte_eth_dev_get_supported_ptyp= es``. > + If application is interested only in L2/L3 layer, it can inform the PM= D to update > + ``rte_mbuf::packet_type`` with L2/L3 ptype by calling > + ``rte_eth_dev_set_supported_ptypes(ethdev_id, RTE_PTYPE_L2_MASK | RTE_P= TYPE_L3_MASK)``. > + This scheme will allow PMDs to avoid writes to ``rte_mbuf`` fields on = Rx and As I understand, PMD will still need to write ptype value. Though it will help PMD to avoid figuring out ptype values, when user don't= need that information. > + thereby improve Rx performance if application wishes do so. > -- > 2.17.1