From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Anoob Joseph <anoobj@marvell.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"Narayana Prasad Raju Athreya" <pathreya@marvell.com>,
Ankur Dwivedi <adwivedi@marvell.com>,
"Shahaf Shuler" <shahafs@mellanox.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
"Matan Azrad" <matan@mellanox.com>,
Yongseok Koh <yskoh@mellanox.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Nicolau, Radu" <radu.nicolau@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC] ethdev: allow multiple security sessions to use one rte flow
Date: Thu, 15 Aug 2019 09:48:26 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB977258018115F7E3@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <MN2PR18MB2877466B2274596C237DD26ADFAC0@MN2PR18MB2877.namprd18.prod.outlook.com>
Hi Anoob,
>
> > > > >
> > > > > The rte_security API which enables inline protocol/crypto feature
> > > > > mandates that for every security session an rte_flow is created.
> > > > > This would internally translate to a rule in the hardware which
> > > > > would do packet
> > > > classification.
> > > > >
> > > > > In rte_securty, one SA would be one security session. And if an
> > > > > rte_flow need to be created for every session, the number of SAs
> > > > > supported by an inline implementation would be limited by the
> > > > > number of rte_flows the PMD would be able to support.
> > > > >
> > > > > If the fields SPI & IP addresses are allowed to be a range, then
> > > > > this limitation can be overcome. Multiple flows will be able to
> > > > > use one rule for SECURITY processing. In this case, the security
> > > > > session provided as
> > > > conf would be NULL.
> >
> > SPI values are normally used to uniquely identify the SA that need to be
> > applied on a particular flow.
> > I believe SPI value should not be a range for applying a particular SA or
> > session.
> >
> > Plain packet IP addresses can be a range. That is not an issue. Multiple plain
> > packet flows can use the same session/SA.
> >
> > Why do you feel that security session provided should be NULL to support
> > multiple flows.
> > How will the keys and other SA related info will be passed to the driver/HW.
>
> [Anoob] The SA configuration would be done via rte_security session. The proposal here only changes the 1:1 dependency of rte_flow and
> rte_security session.
>
> The h/w could use SPI field in the received packet to identify SA(ie, rte_security session). If the h/w allows to index into a table which holds
> SA information, then per SPI rte_flow is not required. This is in fact our case. And for PMDs which doesn't do it this way, rte_flow_validate()
> would fail and then per SPI rte_flow would require to be created.
>
> In the present model, a security session is created, and then rte_flow will connect ESP packets with one SPI to one security session. Instead,
> when we create the security session, h/w can populate entries in a DB that would be accessed during data path handling. And the rte_flow
> could say, all SPI in some range gets inline processed with the security session identified with its SPI.
>
> Our PMD supports limited number of flow entries but our h/w can do SA lookup without flow entries(using SPI instead). So the current
> approach of one flow per session is creating an artificial limit to the number of SAs that can be supported.
QQ: Would that change be accompanied with real implementation for some particular PMD?
Konstantin
>
> >
> > > > >
> > > > > Application should do an rte_flow_validate() to make sure the flow
> > > > > is supported on the PMD.
> > > > >
> > > > > Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> > > > > ---
> > > > > lib/librte_ethdev/rte_flow.h | 6 ++++++
> > > > > 1 file changed, 6 insertions(+)
> > > > >
> > > > > diff --git a/lib/librte_ethdev/rte_flow.h
> > > > > b/lib/librte_ethdev/rte_flow.h index f3a8fb1..4977d3c 100644
> > > > > --- a/lib/librte_ethdev/rte_flow.h
> > > > > +++ b/lib/librte_ethdev/rte_flow.h
> > > > > @@ -1879,6 +1879,12 @@ struct rte_flow_action_meter {
> > > > > * direction.
> > > > > *
> > > > > * Multiple flows can be configured to use the same security session.
> > > > > + *
> > > > > + * The NULL value is allowed for security session. If security
> > > > > + session is NULL,
> > > > > + * then SPI field in ESP flow item and IP addresses in flow items
> > > > > + 'IPv4' and
> > > > > + * 'IPv6' will be allowed to be a range. The rule thus created
> > > > > + can enable
> > > > > + * SECURITY processing on multiple flows.
> > > > > + *
> > > > > */
> > > > > struct rte_flow_action_security {
> > > > > void *security_session; /**< Pointer to security session structure.
> > > > > */
> > > > > --
> > > > > 2.7.4
next prev parent reply other threads:[~2019-08-15 9:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 14:17 Anoob Joseph
2019-08-02 5:35 ` Anoob Joseph
2019-08-14 9:22 ` Anoob Joseph
2019-08-14 11:07 ` Akhil Goyal
2019-08-15 6:49 ` Anoob Joseph
2019-08-15 9:48 ` Ananyev, Konstantin [this message]
2019-08-16 3:24 ` Anoob Joseph
2019-08-16 8:32 ` Akhil Goyal
2019-08-16 10:12 ` Anoob Joseph
2019-08-19 7:09 ` Akhil Goyal
2019-10-08 13:00 ` Yigit, Ferruh
2019-10-09 10:55 ` [dpdk-dev] [EXT] " Anoob Joseph
2019-12-03 5:32 ` Anoob Joseph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB977258018115F7E3@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=adwivedi@marvell.com \
--cc=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=matan@mellanox.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=pathreya@marvell.com \
--cc=radu.nicolau@intel.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).