From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53483A2EEB for ; Thu, 12 Sep 2019 20:08:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3EA741EFE8; Thu, 12 Sep 2019 20:08:29 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id F40EE1EFE7 for ; Thu, 12 Sep 2019 20:08:26 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Sep 2019 11:08:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,498,1559545200"; d="scan'208";a="184875512" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga008.fm.intel.com with ESMTP; 12 Sep 2019 11:08:25 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.164]) by IRSMSX151.ger.corp.intel.com ([169.254.4.234]) with mapi id 14.03.0439.000; Thu, 12 Sep 2019 19:08:24 +0100 From: "Ananyev, Konstantin" To: "Medvedkin, Vladimir" , "dev@dpdk.org" CC: "Iremonger, Bernard" , "akhil.goyal@nxp.com" Thread-Topic: [PATCH v1 2/5] ipsec: add SAD create/free API Thread-Index: AQHVYniEXybrCIGnd0aI11h1XFUEhKcoZH8g Date: Thu, 12 Sep 2019 18:08:24 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772580191964A78@irsmsx105.ger.corp.intel.com> References: <1565709186-273340-1-git-send-email-vladimir.medvedkin@intel.com> <19809d0541aa8fd36156987f0925b498032a1a42.1567529480.git.vladimir.medvedkin@intel.com> In-Reply-To: <19809d0541aa8fd36156987f0925b498032a1a42.1567529480.git.vladimir.medvedkin@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTY2Mzg5YjMtMzUwZC00YTIwLWIyNDctNjBlZThlMzI1NDRjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieDU4TlVoR0NPWmdqeW9GNm1HMXZWZ25iN1FHVHVvRVwvMG80Zng2anFVZDhSSlpxSDRpNkF4UStzV2VDbmlUS3QifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 2/5] ipsec: add SAD create/free API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > --- a/lib/librte_ipsec/ipsec_sad.c > +++ b/lib/librte_ipsec/ipsec_sad.c > @@ -2,10 +2,41 @@ > * Copyright(c) 2019 Intel Corporation > */ >=20 > +#include > #include > +#include > +#include > +#include > +#include > +#include > +#include >=20 > #include "rte_ipsec_sad.h" >=20 > +#define IPSEC_SAD_NAMESIZE 64 > +#define SAD_PREFIX "SAD_" > +/* "SAD_" */ > +#define SAD_FORMAT SAD_PREFIX "%s" > + > +#define DEFAULT_HASH_FUNC rte_jhash > + As a nit - probably worth to add a comment what this structure is for, Aslo might be better to use something more informative for names: dip, dip_sip or so. or even: > +struct hash_cnt { > + uint32_t cnt_2; > + uint32_t cnt_3; > +}; > + > +struct rte_ipsec_sad { > + char name[IPSEC_SAD_NAMESIZE]; > + struct rte_hash *hash[RTE_IPSEC_SAD_KEY_TYPE_MASK]; > + __extension__ struct hash_cnt cnt_arr[]; > +}; > +