Re: [dpdk-dev] [PATCH v2 1/5] ipsec: add inbound SAD API

["Ananyev, Konstantin" <konstantin.ananyev@intel.com>]

Hi Vladimir,

> 
> Add inbound security association database (SAD) API
> and stub implementation.

Whole patch series looks really good from my perspective.
Just few nits here and in other patches.
Konstantin

> --- /dev/null
> +++ b/lib/librte_ipsec/rte_ipsec_sad.h
> @@ -0,0 +1,175 @@
> +
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2019 Intel Corporation
> + */
> +
> +#ifndef _RTE_IPSEC_SAD_H_
> +#define _RTE_IPSEC_SAD_H_
> +
> +#include <rte_compat.h>
> +
> +/**
> + * @file rte_ipsec_sad.h
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> + * RTE IPsec security association database (SAD) support.
> + * It is not recommended to include this file directly,
> + * include <rte_ipsec.h> instead.

Ok..., but rte_ipsec_sad.h is not included into rte_ipsec.h.
Probably just a copy&paste mistake?

> + * Contains helper functions to lookup and maintain SAD
> + */
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif