From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE4FFA2EDB for ; Wed, 2 Oct 2019 13:24:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AD4571BED4; Wed, 2 Oct 2019 13:24:20 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 62D071BEC8 for ; Wed, 2 Oct 2019 13:24:18 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2019 04:24:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,574,1559545200"; d="scan'208";a="343303695" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga004.jf.intel.com with ESMTP; 02 Oct 2019 04:24:16 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.164]) by IRSMSX107.ger.corp.intel.com ([169.254.10.7]) with mapi id 14.03.0439.000; Wed, 2 Oct 2019 12:24:15 +0100 From: "Ananyev, Konstantin" To: "Medvedkin, Vladimir" , "dev@dpdk.org" CC: "Iremonger, Bernard" , "akhil.goyal@nxp.com" Thread-Topic: [PATCH v2 1/5] ipsec: add inbound SAD API Thread-Index: AQHVeH1OtmYSOXM42k6xVKNWru1FX6dHNZzg Date: Wed, 2 Oct 2019 11:24:14 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258019196FD14@irsmsx105.ger.corp.intel.com> References: In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2NkOWZmMjgtZjQ2NC00ZGUxLThhNjQtMDM0ZDM2MzlmMWExIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidFhGa2FWNE5yWjA1SmxjdGtSc2M0ZVVXRWNJTXY3OUthMktzZDZcL2RuXC9sc3VSU2xLajBaWUJScVc4QVwvMm90WCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/5] ipsec: add inbound SAD API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Vladimir, >=20 > Add inbound security association database (SAD) API > and stub implementation. Whole patch series looks really good from my perspective. Just few nits here and in other patches. Konstantin > --- /dev/null > +++ b/lib/librte_ipsec/rte_ipsec_sad.h > @@ -0,0 +1,175 @@ > + > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2019 Intel Corporation > + */ > + > +#ifndef _RTE_IPSEC_SAD_H_ > +#define _RTE_IPSEC_SAD_H_ > + > +#include > + > +/** > + * @file rte_ipsec_sad.h > + * @b EXPERIMENTAL: this API may change without prior notice > + * > + * RTE IPsec security association database (SAD) support. > + * It is not recommended to include this file directly, > + * include instead. Ok..., but rte_ipsec_sad.h is not included into rte_ipsec.h. Probably just a copy&paste mistake? > + * Contains helper functions to lookup and maintain SAD > + */ > + > +#ifdef __cplusplus > +extern "C" { > +#endif