From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6346A3160 for ; Wed, 9 Oct 2019 10:29:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 81E391D422; Wed, 9 Oct 2019 10:29:41 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id CC2311D408 for ; Wed, 9 Oct 2019 10:29:39 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2019 01:29:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,273,1566889200"; d="scan'208";a="183995793" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga007.jf.intel.com with ESMTP; 09 Oct 2019 01:29:37 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.164]) by IRSMSX152.ger.corp.intel.com ([169.254.6.150]) with mapi id 14.03.0439.000; Wed, 9 Oct 2019 09:29:31 +0100 From: "Ananyev, Konstantin" To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: "Doherty, Declan" , "akhil.goyal@nxp.com" Thread-Topic: [PATCH v2 05/10] crypto/aesni_mb: add rte_security handler Thread-Index: AQHVfSxoLUFVPrmQ8E+Fsep2YzjCQKdR+5rw Date: Wed, 9 Oct 2019 08:29:30 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258019197406A@irsmsx105.ger.corp.intel.com> References: <20190906131330.40185-1-roy.fan.zhang@intel.com> <20191007162850.60552-1-roy.fan.zhang@intel.com> <20191007162850.60552-6-roy.fan.zhang@intel.com> In-Reply-To: <20191007162850.60552-6-roy.fan.zhang@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjNlZTMzMWYtY2U5OS00ZWIwLTk0YWItYTliZjAyMzU4NjQzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicmNIWTRxN2lHbDBtOUpcL2ZYRnZUTk40YWpTUkNuT2Q1VzlCc08wdWlzejB6MnBTZXZqcnFsZytNc0I4MDZDalAifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 05/10] crypto/aesni_mb: add rte_security handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > + /* setup security operations */ > + snprintf(sec_name, sizeof(sec_name) - 1, "aes_mb_sec_%u", > + dev->driver_id); Just a nit here and in aesni_gcm code: this is useless actually, rte_malloc ignores name argument. You can safely pass NULL here. > + sec_ctx =3D rte_zmalloc_socket(sec_name, > + sizeof(struct rte_security_ctx), > + RTE_CACHE_LINE_SIZE, init_params->socket_id); > + if (sec_ctx =3D=3D NULL) { > + AESNI_MB_LOG(ERR, "memory allocation failed\n"); > + goto error_exit; > + } > + > + sec_ctx->device =3D (void *)dev; > + sec_ctx->ops =3D rte_aesni_mb_pmd_security_ops; > + dev->security_ctx =3D sec_ctx; > + > return 0; >=20 > error_exit: > if (mb_mgr) > free_mb_mgr(mb_mgr); > + if (sec_ctx) > + rte_free(sec_ctx); >=20 > rte_cryptodev_pmd_destroy(dev); >=20