From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id EB8902E8E for ; Mon, 13 Jan 2014 12:17:14 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 13 Jan 2014 03:18:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.95,652,1384329600"; d="scan'208";a="437970068" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga001.jf.intel.com with ESMTP; 13 Jan 2014 03:18:24 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.215]) by IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0123.003; Mon, 13 Jan 2014 11:18:23 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon , Daniel Kan Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix RSS rx by setting mq_mode Thread-Index: AQHPEEqQEmHPac4c9ESm0CyWR98ok5qCfbQg Date: Mon, 13 Jan 2014 11:18:22 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725808E4ED39@IRSMSX105.ger.corp.intel.com> References: <1389408367-19376-1-git-send-email-dan@nyansa.com> <201401131131.06203.thomas.monjalon@6wind.com> In-Reply-To: <201401131131.06203.thomas.monjalon@6wind.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix RSS rx by setting mq_mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jan 2014 11:17:15 -0000 Hi Daniel, Good catch :) We plan to deliver a fix for that bug in coming DPDK release. It is very similar to yours one, though we need extra check that there are = no VFs enabled for that port. Thanks Konstantin = -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon Sent: Monday, January 13, 2014 10:31 AM To: Daniel Kan Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix RSS rx by setting mq_mode Hello, 11/01/2014 03:46, Daniel Kan: > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1546,6 +1546,9 @@ init_port_config(void) > if (nb_rxq > 0) { > port->dev_conf.rx_adv_conf.rss_conf.rss_key =3D NULL; > port->dev_conf.rx_adv_conf.rss_conf.rss_hf =3D rss_hf; > + if (nb_rxq > 1 && rss_hf !=3D 0) { > + port->dev_conf.rxmode.mq_mode =3D ETH_MQ_RX_RSS; > + } The fix looks good. Thanks. Please, could you add a detailed explanation and a signed-off as described = in the guidelines: http://dpdk.org/dev#send I think it's a good idea to point to the commit which has introduced the bu= g. Note also that "RSS rx" may be simply "RSS". Thank you -- Thomas -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others = is strictly prohibited. If you are not the intended recipient, please conta= ct the sender and delete all copies.