From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 4F26D594F
 for <dev@dpdk.org>; Thu, 22 May 2014 17:51:11 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga101.fm.intel.com with ESMTP; 22 May 2014 08:51:20 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.98,887,1392192000"; d="scan'208";a="536102347"
Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155])
 by fmsmga001.fm.intel.com with ESMTP; 22 May 2014 08:51:19 -0700
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.70]) by
 IRSMSX102.ger.corp.intel.com ([169.254.2.173]) with mapi id 14.03.0123.003;
 Thu, 22 May 2014 16:51:05 +0100
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] rte_pktmbuf_alloc fails
Thread-Index: AQHPTZrHVVc8358MfkSbsYwzq1Jn0ptNDx6cgAAAKtA=
Date: Thu, 22 May 2014 15:51:04 +0000
Message-ID: <2601191342CEEE43887BDE71AB9772580EFA81D9@IRSMSX105.ger.corp.intel.com>
References: <CA+Typ9mJRUhSbOME=r3KFADxykKYN8snVAZ1JUEf8ohXbz-W7w@mail.gmail.com>
 <2601191342CEEE43887BDE71AB9772580EF94DE9@IRSMSX105.ger.corp.intel.com>
 <2441602.aZ8JVAEsGZ@xps13> <3243438.tFUQaShmoV@xps13>
In-Reply-To: <3243438.tFUQaShmoV@xps13>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] rte_pktmbuf_alloc fails
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 22 May 2014 15:51:11 -0000

Hi Thomas,
I planned to, but very unlikely that it would happen that week.
Thanks
Konstantin

-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20
Sent: Thursday, May 22, 2014 4:47 PM
To: Ananyev, Konstantin
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] rte_pktmbuf_alloc fails

2014-04-17 17:00, Thomas Monjalon:
> Hi Konstantin,
>=20
> 2014-04-07 08:53, Ananyev, Konstantin:
> > Yep indeed, there is a bug in eth_pcap_tx() that can cause mbuf
> > corruption.
> > I think it should be something like that instead:
> >=20
> > --- a/lib/librte_pmd_pcap/rte_eth_pcap.c
> > +++ b/lib/librte_pmd_pcap/rte_eth_pcap.c
> > @@ -205,8 +205,9 @@ eth_pcap_tx(void *queue,
> >=20
> >                 mbuf =3D bufs[i];
> >                 ret =3D pcap_sendpacket(tx_queue->pcap, (u_char*)
> >=20
> > mbuf->pkt.data, mbuf->pkt.data_len);
> > -               if(likely(!ret))
> > -                       num_tx++;
> > +               if(unlikely(ret !=3D 0))
> > +                       break;
> > +               num_tx++;
> >=20
> >                 rte_pktmbuf_free(mbuf);
> >        =20
> >         }
>=20
> Please could you send a patch with a commit log as described in
> http://dpdk.org/dev#send ?

I think you haven't sent patch for this bug.
Do you plan to do so?

Thanks
--=20
Thomas