From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 47B43B379 for ; Thu, 28 Aug 2014 13:26:14 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 28 Aug 2014 04:22:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,417,1406617200"; d="scan'208";a="582840643" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga001.fm.intel.com with ESMTP; 28 Aug 2014 04:30:15 -0700 Received: from irsmsx154.ger.corp.intel.com (163.33.192.96) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 28 Aug 2014 12:30:15 +0100 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.158]) by IRSMSX154.ger.corp.intel.com ([169.254.12.233]) with mapi id 14.03.0195.001; Thu, 28 Aug 2014 12:30:15 +0100 From: "Ananyev, Konstantin" To: Thomas Monjalon , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config functions for i40e flow director support Thread-Index: AQHPwq9v/yc0emyiC0ePLIgHQ1gySZvl31gw Date: Thu, 28 Aug 2014 11:30:14 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772582135F37F@IRSMSX105.ger.corp.intel.com> References: <1409105634-29980-1-git-send-email-jingjing.wu@intel.com> <6406194.6E43HquPHH@xps13> <9BB6961774997848B5B42BEC655768F8ADC10D@SHSMSX104.ccr.corp.intel.com> <32773310.iMGaa2PpNO@xps13> In-Reply-To: <32773310.iMGaa2PpNO@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config functions for i40e flow director support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Aug 2014 11:26:14 -0000 > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, August 28, 2014 12:01 PM > To: Wu, Jingjing > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and confi= g functions for i40e flow director support >=20 > 2014-08-28 09:01, Wu, Jingjing: > > I have another question: > > If we use the way 'rx_classification_filter_ctl' works, the specific > > structures defined in rte_i40e.h will be visible in user's application, > > such as testpmd. > > I know I shouldn't make commands linked with i40e like what I did befor= e. > > But will the i40e specific structures become visible be acceptable? >=20 > I think testpmd should be limited to generic API. > So it wouldn't be acceptable to be dependent of i40e files. > But having some specific i40e tests in examples or app/test is OK. >=20 Probably I didn't get you right: Are you suggesting to have a new clone of testpmd for any new device we are= going to support? That seems like too much hassle to me. Plus what to do if someone would like to test configuration with two differ= ent devices involved: ixgbe and i40e for example?=20 I suggest we keep one testpmd for all devices we support. Of course we'll probably have to make some rework to avoid if (strncmp(drv_= name, "xxx") spread all over it. We need to find some better way to discover/setup HW specific features. Thanks Konstantin