From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C0FDE7E18 for ; Tue, 18 Nov 2014 12:23:07 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 18 Nov 2014 03:33:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,409,1413270000"; d="scan'208";a="624168286" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga001.fm.intel.com with ESMTP; 18 Nov 2014 03:33:25 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.144]) by IRSMSX152.ger.corp.intel.com ([169.254.6.56]) with mapi id 14.03.0195.001; Tue, 18 Nov 2014 11:33:25 +0000 From: "Ananyev, Konstantin" To: "Liu, Jijiang" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 0/4] Translate packet types for i40e Thread-Index: AQHQAwKdtAq8eAMesEe9YHLlK90XlpxmOTcw Date: Tue, 18 Nov 2014 11:33:24 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213B581A@IRSMSX105.ger.corp.intel.com> References: <1416296251-7534-1-git-send-email-jijiang.liu@intel.com> In-Reply-To: <1416296251-7534-1-git-send-email-jijiang.liu@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/4] Translate packet types for i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Nov 2014 11:23:08 -0000 Hi Frank, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu > Sent: Tuesday, November 18, 2014 7:37 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 0/4] Translate packet types for i40e >=20 > The i40e NIC can recognize many packet types, including ordinary L2 packe= t format and tunneling packet format such as IP in IP, IP in > GRE, MAC in GRE and MAC in UDP. >=20 > This patch set provides abstract definitions of packet types, > which can help user to use these packet types directly in their applicati= ons to speed up receive packet analysis. >=20 > Moreover, this patch set translates i40e packet types to abstract packet = types in i40e driver, > and make the corresponding changes in test applications. >=20 > Jijiang Liu (4): > Add packet type and IP header check in rte_mbuf > Remove the PKT_RX_TUNNEL_IPV4_HDR and the PKT_RX_TUNNEL_IPV6_HDR > Translate i40e packet types > Make the corresponding changes in test-pmd >=20 > app/test-pmd/csumonly.c | 12 +- > app/test-pmd/rxonly.c | 15 +- > lib/librte_mbuf/rte_mbuf.h | 225 ++++++++++++++- > lib/librte_pmd_i40e/i40e_rxtx.c | 604 +++++++++++++++++++++------------= ------ > 4 files changed, 569 insertions(+), 287 deletions(-) >=20 The patch looks good to me in general. Though I think it is not complete: we need to make sure that all PMDs RX fu= nctions will set mbuf's packet_type to the defined value. As right now, only i40e implementation can distinguish packet_type properly= , I think all other PMDs for the freshly received packet should do: mbuf->packet_type =3D RTE_PTYPE_UNDEF; =20 Another thing: right now mbuf's packet_type is uint16_t. While enum rte_eth_packet_type will be interpreted by the compiler as 'int'= (32bits). We can either change enum to a lot of defines (which I don't really like to= do) or probably just add a comment somewhere that enum rte_eth_packet_type should never exceed = UINT16_MAX value? Konstantin > -- > 1.7.7.6