From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id B2ACC66FC for ; Tue, 27 Jan 2015 16:26:23 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 27 Jan 2015 07:22:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="445881284" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by FMSMGA003.fm.intel.com with ESMTP; 27 Jan 2015 07:12:38 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.81]) by IRSMSX152.ger.corp.intel.com ([169.254.6.43]) with mapi id 14.03.0195.001; Tue, 27 Jan 2015 15:26:19 +0000 From: "Ananyev, Konstantin" To: Olivier MATZ , "Liu, Jijiang" , "Zhang, Helin" Thread-Topic: [dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine Thread-Index: AQHQFSvOf5ZHcwOIQ0S6LPFf4KIhoZyLUqAAgADVrYCAJ+m7AIAAhGKAgAAcY4CAAAaCgIABXQMAgAAfBJCAAZMJAIAEQKUAgACGkwCAAQFCAIAAcvAAgAEemACAAkDH8IAB1gMAgARiT1CAACVrgIAAHEZAgAFUrACAADW5sIAAKFUAgACV94CAAMyvAIAHCkRwgAA0QACAAIdbAIAAAJsQgAE0rACAAHLb4A== Date: Tue, 27 Jan 2015 15:26:19 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213DFEAF@irsmsx105.ger.corp.intel.com> References: <1418173403-30202-1-git-send-email-jijiang.liu@intel.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01DA8E36@SHSMSX101.ccr.corp.intel.com> <54B4EB92.40209@6wind.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01DB0789@SHSMSX101.ccr.corp.intel.com> <2601191342CEEE43887BDE71AB977258213D4FCF@irsmsx105.ger.corp.intel.com> <54B94A18.5030700@6wind.com> <2601191342CEEE43887BDE71AB977258213DCD25@irsmsx105.ger.corp.intel.com> <54BD16F1.6050409@6wind.com> <2601191342CEEE43887BDE71AB977258213DDF46@irsmsx105.ger.corp.intel.com> <54BE4C70.7050406@6wind.com> <2601191342CEEE43887BDE71AB977258213DE5FB@irsmsx105.ger.corp.intel.com> <54BE9B56.7050108@6wind.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01DB55DB@SHSMSX101.ccr.corp.intel.com> <54BFC4D6.2010903@6wind.com> <2601191342CEEE43887BDE71AB977258213DF71B@irsmsx105.ger.corp.intel.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01DB6FD2@SHSMSX101.ccr.corp.intel.com> <54C64A10.2010906@6wind.com> <2601191342CEEE43887BDE71AB977258213DF90B@irsmsx105.ger.corp.intel.com> <54C74D80.7090208@6wind.com> In-Reply-To: <54C74D80.7090208@6wind.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2015 15:26:24 -0000 Hi Olivier, > -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > Sent: Tuesday, January 27, 2015 8:34 AM > To: Ananyev, Konstantin; Liu, Jijiang; Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and cs= um forwarding engine >=20 > Hi Konstantin, >=20 > On 01/26/2015 03:15 PM, Ananyev, Konstantin wrote: > >>>> Another thing - IPIP seems to work ok by HW. > >>>> There is something wrong on our (PMD/test-pmd) side. > >>>> I think at least we have to remove the following check: > >>>> if (!l2_len) { > >>>> PMD_DRV_LOG(DEBUG, "L2 length set to 0"); > >>>> return; > >>>> } > >>>> in i40e_txd_enable_checksum(). > >>> > >>> Yes, for IPIP, the check should be removed. > >> > >> Yes, I think these lines should be removed for 2 reasons: > >> - it may be the cause of ipip tunnel not working > >> - we shouldn't do these kind of tests in dataplane. I think we have to > >> suppose that the data passed to the PMD is valid. > >> > >> I'll redo the test with ipip tomorrow with this fix and let you > >> know the result. If it works, I'll add this in the next version > >> of the patch. > > > > While you are on this, can I suggest you'll add debug logging for TCD a= nd TDD we are writing to the TX ring? > > Something like that: > > > > + PMD_TX_LOG(DEBUG, "mbuf: %p, TCD[%u]:\n" > > + "tunneling_params: %#x;\n" > > + "l2tag2: %#hx;\n" > > + "rsvd: %#hx;\n" > > + "type_cmd_tso_mss: %#lx;\n", > > + tx_pkt, tx_id, > > + ctx_txd->tunneling_params, > > + ctx_txd->l2tag2, > > + ctx_txd->rsvd, > > + ctx_txd->type_cmd_tso_mss); > > > > And same for TDD. > > It helped me a lot to figure out what is going on, when I did my tests= . > > Probably would be useful for other people too. >=20 > Sure, I'll add this. >=20 > Also, just to let you know that I tested the ipip case without the > "if (l2_len) return" and "if (l3_len) return", and it is working. That's great. Thanks Konstantin >=20 > Regards, > Olivier