From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 0E05B959
 for <dev@dpdk.org>; Fri, 13 Mar 2015 10:45:26 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga103.jf.intel.com with ESMTP; 13 Mar 2015 02:42:01 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,393,1422950400"; d="scan'208";a="664731847"
Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59])
 by orsmga001.jf.intel.com with ESMTP; 13 Mar 2015 02:44:59 -0700
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.117]) by
 IRSMSX151.ger.corp.intel.com ([169.254.4.7]) with mapi id 14.03.0195.001;
 Fri, 13 Mar 2015 09:44:59 +0000
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Qiu, Michael" <michael.qiu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed
Thread-Index: AQHQXVvUO05hIRMUZ0OMqlZLgC1jiZ0aKOyg
Date: Fri, 13 Mar 2015 09:44:58 +0000
Message-ID: <2601191342CEEE43887BDE71AB977258213F5E13@irsmsx105.ger.corp.intel.com>
References: <1426230179-1891-1-git-send-email-michael.qiu@intel.com>
In-Reply-To: <1426230179-1891-1-git-send-email-michael.qiu@intel.com>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Mar 2015 09:45:27 -0000

Hi Michael,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu
> Sent: Friday, March 13, 2015 7:03 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed
>=20
> rte_memcpy.h(46): catastrophic error: cannot open source file "x86intrin.=
h"
>=20
> For icc and old gcc, this header is not included.
>=20
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> ---
>  lib/librte_eal/common/include/arch/x86/rte_memcpy.h | 20 +++++++++++++++=
+++++
>  1 file changed, 20 insertions(+)
>=20
> diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h b/lib/li=
brte_eal/common/include/arch/x86/rte_memcpy.h
> index ac72069..bd10d36 100644
> --- a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h
> +++ b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h
> @@ -43,7 +43,27 @@
>  #include <stdio.h>
>  #include <stdint.h>
>  #include <string.h>
> +#if (defined(__ICC) || (__GNUC__ =3D=3D 4 &&  __GNUC_MINOR__ < 4))
> +
> +#ifdef __SSE__
> +#include <xmmintrin.h>
> +#endif
> +
> +#ifdef __SSE2__
> +#include <emmintrin.h>
> +#endif
> +
> +#if defined(__SSE4_2__) || defined(__SSE4_1__)
> +#include <smmintrin.h>
> +#endif
> +
> +#if defined(__AVX__)
> +#include <immintrin.h>
> +#endif
> +
> +#else
>  #include <x86intrin.h>
> +#endif
>=20
>  #ifdef __cplusplus
>  extern "C" {
> --
> 1.9.3

Wonder why to spread this thing over?
Why not just #include <rte_common_vec.h>?

Konstantin