From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id AADD558D8 for ; Fri, 13 Mar 2015 12:07:50 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP; 13 Mar 2015 04:02:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,394,1422950400"; d="scan'208";a="698233871" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga002.jf.intel.com with ESMTP; 13 Mar 2015 04:07:49 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.117]) by IRSMSX153.ger.corp.intel.com ([169.254.9.234]) with mapi id 14.03.0195.001; Fri, 13 Mar 2015 11:07:48 +0000 From: "Ananyev, Konstantin" To: Vlad Zolotarov , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 0/3]: bug fixes in the ixgbe PF PMD Rx flow Thread-Index: AQHQXQoBZ3udwfBmB0m/yrG9sOLV350aQNgw Date: Fri, 13 Mar 2015 11:07:47 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213F5E9B@irsmsx105.ger.corp.intel.com> References: <1426195052-4640-1-git-send-email-vladz@cloudius-systems.com> In-Reply-To: <1426195052-4640-1-git-send-email-vladz@cloudius-systems.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 0/3]: bug fixes in the ixgbe PF PMD Rx flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Mar 2015 11:07:51 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Vlad Zolotarov > Sent: Thursday, March 12, 2015 9:17 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 0/3]: bug fixes in the ixgbe PF PMD Rx flow >=20 > This series contains some bug fixes that were found during my work on the= ixgbe LRO > patches. Sending this series separately on Thomas request so that it may = be integrated > into the 2.0 release. >=20 > New in v3: > - Adjusted to the new structs naming in the master. > - Fixed rx_bulk_alloc_allowed and rx_vec_allowed initialization: > - Don't set them to FALSE in rte_eth_dev_stop() flow - the followin= g > rte_eth_dev_start() will need them. > - Reset them to TRUE in rte_eth_dev_configure() and not in a probe(= ) flow. > This will ensure the proper behaviour if port is re-configured. > - Rename: > - ixgbe_rx_vec_condition_check() -> ixgbe_rx_vec_dev_conf_condition= _check() > - set_rx_function() -> ixgbe_set_rx_function() > - Clean up the logic in ixgbe_set_rx_function(). > - Define stubs with __attribute__((weak)) instead of using #ifdef's. > - Styling: beautify ixgbe_rxtx.h a bit. >=20 > New in v2: > - Fixed a compilation failure. >=20 >=20 > Vlad Zolotarov (3): > ixgbe: Use the rte_le_to_cpu_xx()/rte_cpu_to_le_xx() when > reading/setting HW ring descriptor fields > ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices > ixgbe: Unify the rx_pkt_bulk callback initialization >=20 > lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 2 + > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 13 +- > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 216 +++++++++++++++++++++-----= ------ > lib/librte_pmd_ixgbe/ixgbe_rxtx.h | 28 ++++- > lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 2 +- > 5 files changed, 183 insertions(+), 78 deletions(-) >=20 Acked-by: Konstantin Ananyev Just one nit: +int __attribute__((weak)) ixgbe_rxq_vec_setup( + struct ixgbe_rx_queue __rte_unused *rxq) +{ Please use notation: int __attribute__((weak)) ixgbe_rxq_vec_setup(struct ixgbe_rx_queue __rte_unused *rxq) To keep up with the rest of the code, plus makes much easier to read. > -- > 2.1.0