From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 528A2568F for ; Mon, 16 Mar 2015 18:39:34 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 16 Mar 2015 10:33:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,410,1422950400"; d="scan'208";a="692901102" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga002.fm.intel.com with ESMTP; 16 Mar 2015 10:39:32 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.117]) by IRSMSX153.ger.corp.intel.com ([169.254.9.234]) with mapi id 14.03.0195.001; Mon, 16 Mar 2015 17:39:32 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed Thread-Index: AQHQXVvUO05hIRMUZ0OMqlZLgC1jiZ0aKOyggAUiW4CAABaPgA== Date: Mon, 16 Mar 2015 17:39:31 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213F6BEB@irsmsx105.ger.corp.intel.com> References: <1426230179-1891-1-git-send-email-michael.qiu@intel.com> <2601191342CEEE43887BDE71AB977258213F5E13@irsmsx105.ger.corp.intel.com> <6230385.qXqGPvIMiq@xps13> In-Reply-To: <6230385.qXqGPvIMiq@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Mar 2015 17:39:34 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, March 16, 2015 4:05 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; Qiu, Michael > Subject: Re: [dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed >=20 > 2015-03-13 09:44, Ananyev, Konstantin: > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu > > > > > > rte_memcpy.h(46): catastrophic error: cannot open source file "x86int= rin.h" > > > > > > For icc and old gcc, this header is not included. > > > > > > Signed-off-by: Michael Qiu > > > --- > > > lib/librte_eal/common/include/arch/x86/rte_memcpy.h | 20 +++++++++++= +++++++++ > > > 1 file changed, 20 insertions(+) > > > > > > diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h b/li= b/librte_eal/common/include/arch/x86/rte_memcpy.h > > > index ac72069..bd10d36 100644 > > > --- a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > > > +++ b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > > > @@ -43,7 +43,27 @@ > > > #include > > > #include > > > #include > > > +#if (defined(__ICC) || (__GNUC__ =3D=3D 4 && __GNUC_MINOR__ < 4)) > > > + > > > +#ifdef __SSE__ > > > +#include > > > +#endif > > > + > > > +#ifdef __SSE2__ > > > +#include > > > +#endif > > > + > > > +#if defined(__SSE4_2__) || defined(__SSE4_1__) > > > +#include > > > +#endif > > > + > > > +#if defined(__AVX__) > > > +#include > > > +#endif > > > + > > > +#else > > > #include > > > +#endif > > > > > > #ifdef __cplusplus > > > extern "C" { > > > -- > > > 1.9.3 > > > > Wonder why to spread this thing over? > > Why not just #include ? >=20 > I agree to use rte_common_vec.h. > I pushed this approach to check every tested compilers: > http://dpdk.org/browse/dpdk/commit/?id=3D9a01c31b94e54384 >=20 > I think that rte_common_vec.h should be moved into > lib/librte_eal/common/include/arch/x86/rte_vec.h as it's x86-specific. Seems like a good thing to do. Do you want me to submit a patch for 2.0 for that? Konstantin