From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 568975A9A
 for <dev@dpdk.org>; Thu,  4 Jun 2015 12:20:49 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga101.jf.intel.com with ESMTP; 04 Jun 2015 03:20:27 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,552,1427785200"; d="scan'208";a="736948502"
Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59])
 by fmsmga002.fm.intel.com with ESMTP; 04 Jun 2015 03:20:26 -0700
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.73]) by
 IRSMSX151.ger.corp.intel.com ([169.254.4.102]) with mapi id 14.03.0224.002;
 Thu, 4 Jun 2015 11:20:25 +0100
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH 0/8] ACL: various fixes and cleanups
Thread-Index: AQHQnlKIH2QV1ac5/UWr+72E0sxE0Z2cA/GAgAAe+MA=
Date: Thu, 4 Jun 2015 10:20:25 +0000
Message-ID: <2601191342CEEE43887BDE71AB97725821434ED7@irsmsx105.ger.corp.intel.com>
References: <1433373024-5558-1-git-send-email-konstantin.ananyev@intel.com>
 <33335664.AQckXK60Ox@xps13>
In-Reply-To: <33335664.AQckXK60Ox@xps13>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 0/8] ACL: various fixes and cleanups
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Jun 2015 10:20:49 -0000

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, June 04, 2015 10:27 AM
> To: Ananyev, Konstantin
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 0/8] ACL: various fixes and cleanups
>=20
> Hi Konstantin,
>=20
> 2015-06-04 00:10, Konstantin Ananyev:
> > This patch-set is based on:
> > [PATCHv2 0/3] ACL: Fix bug in acl_merge_trie() and add a new test-case =
for it to the UT.
> >
> > Konstantin Ananyev (8):
> >  ACL: fix invalid rule wildness calculation for RTE_ACL_FIELD_TYPE_BITM=
ASK
> >  ACL: code cleanup - use global RTE_LEN2MASK macro
> >  ACL: add function to check rte_acl_build() input parameters
> >  ACL: fix rebuilding a trie for subset of rules
> >  ACL: introduce RTE_ACL_MASKLEN_TO_BITMASK macro
> >  ACL: cleanup remove unused code from acl_bld.c
> >  ACL: fix remove ambiguity between rules at UT
> >  ACL: add new test-cases into UT
>=20
> Commit titles would be more useful if they shortly explain the goal inste=
ad
> of giving some function/macro names. It should be thought as a changelog =
entry
> and reflect behavioral change.

There is no changes in behaviour.
Just fixes and clean-ups.

> On a side note, the keyword ACL: should be lowercase.
>=20
> In the case of fixes, adding a Fixes: line may help.
> It can be generated with this command:
> 	git log -1 --abbrev=3D12 --format=3D'Fixes: %h ("%s")' <commit>

Ok, will update commit messages in v2.
Konstantin

>=20
> Thanks