From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id D0394376D
 for <dev@dpdk.org>; Wed,  9 Sep 2015 10:22:49 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga101.jf.intel.com with ESMTP; 09 Sep 2015 01:22:48 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,495,1437462000"; d="scan'208";a="801296740"
Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75])
 by fmsmga002.fm.intel.com with ESMTP; 09 Sep 2015 01:22:46 -0700
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.51]) by
 IRSMSX153.ger.corp.intel.com ([169.254.9.13]) with mapi id 14.03.0224.002;
 Wed, 9 Sep 2015 09:22:46 +0100
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: =?iso-8859-1?Q?Simon_K=E5gstr=F6m?= <simon.kagstrom@netinsight.net>,
 "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v2] mbuf/ip_frag: Move mbuf chaining to common code
Thread-Index: AQHQ6WJyu9dOoHLyNkKQrAkIM5z28J4w/MMA///0rICAAMKMAIAAriWAgADsbDA=
Date: Wed, 9 Sep 2015 08:22:45 +0000
Message-ID: <2601191342CEEE43887BDE71AB97725836A84911@irsmsx105.ger.corp.intel.com>
References: <20150831144110.4a7afa27@miho>	<55ED3D9A.7070607@6wind.com>
 <2601191342CEEE43887BDE71AB97725836A83CBA@irsmsx105.ger.corp.intel.com>
 <55ED5A6A.1000803@6wind.com>	<55ED69BA.4010803@netinsight.net>
 <20150907134324.2d418bd4@miho>
 <2601191342CEEE43887BDE71AB97725836A83E71@irsmsx105.ger.corp.intel.com>
 <55ED85EB.2030102@netinsight.net>
 <2601191342CEEE43887BDE71AB97725836A841A7@irsmsx105.ger.corp.intel.com>
 <55EEBB33.6050300@netinsight.net>
In-Reply-To: <55EEBB33.6050300@netinsight.net>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] mbuf/ip_frag: Move mbuf chaining to
	common code
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Sep 2015 08:22:50 -0000



> -----Original Message-----
> From: Simon K=E5gstr=F6m [mailto:simon.kagstrom@netinsight.net]
> Sent: Tuesday, September 08, 2015 11:41 AM
> To: Ananyev, Konstantin; dev@dpdk.org
> Cc: Olivier MATZ; Zhang, Helin; Gonzalez Monroy, Sergio; Burakov, Anatoly
> Subject: Re: [PATCH v2] mbuf/ip_frag: Move mbuf chaining to common code
>=20
> On 2015-09-08 01:21, Ananyev, Konstantin wrote:
> >>
> >> Thanks. I got it wrong anyway, what I wanted was to be able to handle
> >> the day when nb_segs changes to a 16-bit number, but then it should
> >> really be
> >>
> >>   ... >=3D 1 << (sizeof(head->nb_segs) * 8)
> >>
> >> anyway. I'll fix that and also add a warning that the implementation
> >> will do a linear search to find the tail entry.
> >
> > Probably just me, but I can't foresee the situation when  we would need=
 to increase nb_segs to 16 bits.
> > Looks like an overkill to me.
>=20
> I don't think it will happen either, but with this solution, this
> particular piece of code will work regardless. The value is known at
> compile-time anyway, so it should not be a performance issue.

Ok :)
Konstantin

>=20
> // Simon