From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 95B9E58D4 for ; Thu, 10 Sep 2015 10:35:57 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 10 Sep 2015 01:35:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,503,1437462000"; d="scan'208";a="642075852" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga003.jf.intel.com with ESMTP; 10 Sep 2015 01:35:12 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.224.2; Thu, 10 Sep 2015 09:35:10 +0100 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.51]) by irsmsx112.ger.corp.intel.com ([169.254.1.110]) with mapi id 14.03.0224.002; Thu, 10 Sep 2015 09:35:10 +0100 From: "Ananyev, Konstantin" To: "Azarewicz, PiotrX T" , "dev@dpdk.org" Thread-Topic: [PATCH v4 1/1] ip_frag: fix creating ipv6 fragment extension header Thread-Index: AQHQ65gDF/tyom51akyeoW1yPncQFJ41bycw Date: Thu, 10 Sep 2015 08:35:09 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836A85059@irsmsx105.ger.corp.intel.com> References: <1441805945-19889-1-git-send-email-piotrx.t.azarewicz@intel.com> <1441868957-20479-1-git-send-email-piotrx.t.azarewicz@intel.com> In-Reply-To: <1441868957-20479-1-git-send-email-piotrx.t.azarewicz@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/1] ip_frag: fix creating ipv6 fragment extension header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Sep 2015 08:35:58 -0000 > -----Original Message----- > From: Azarewicz, PiotrX T > Sent: Thursday, September 10, 2015 8:09 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian; Ananyev, Konstantin; Azarewicz, PiotrX T > Subject: [PATCH v4 1/1] ip_frag: fix creating ipv6 fragment extension hea= der >=20 > Previous implementation won't work on every environment. The order of > allocation of bit-fields within a unit (high-order to low-order or > low-order to high-order) is implementation-defined. > Solution: used bytes instead of bit fields. >=20 > v2 changes: > - remove useless union > - fix process_ipv6 function (due to remove the union above) >=20 > v3 changes: > - add macros to read/set fragment_offset and more_flags values >=20 > v4 changes: > - two additional fixes due to remove the union and due to changes in > macros >=20 > Signed-off-by: Piotr Azarewicz Acked-by: Konstantin Ananyev > ---