From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 62FA08DB4 for ; Fri, 30 Oct 2015 12:38:48 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 30 Oct 2015 04:38:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,217,1444719600"; d="scan'208";a="590966278" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by FMSMGA003.fm.intel.com with ESMTP; 30 Oct 2015 04:38:42 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.75]) by IRSMSX109.ger.corp.intel.com ([169.254.13.139]) with mapi id 14.03.0248.002; Fri, 30 Oct 2015 11:38:41 +0000 From: "Ananyev, Konstantin" To: "De Lara Guarch, Pablo" , "Mrzyglod, DanielX T" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 4/6] i40e: add additional ieee1588 support functions Thread-Index: AQHREwbHfuNkqOaCNESbWg6YcUgyxZ6D6CTg Date: Fri, 30 Oct 2015 11:38:40 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836AB6F27@irsmsx105.ger.corp.intel.com> References: <1443799208-9408-1-git-send-email-danielx.t.mrzyglod@intel.com> <1446198204-9852-1-git-send-email-danielx.t.mrzyglod@intel.com> <1446198204-9852-5-git-send-email-danielx.t.mrzyglod@intel.com> <2601191342CEEE43887BDE71AB97725836AB6EC2@irsmsx105.ger.corp.intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 4/6] i40e: add additional ieee1588 support functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2015 11:38:48 -0000 > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Friday, October 30, 2015 11:33 AM > To: Ananyev, Konstantin; Mrzyglod, DanielX T; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 4/6] i40e: add additional ieee1588 supp= ort functions >=20 > Hi Konstantin, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ananyev, > > Konstantin > > Sent: Friday, October 30, 2015 11:20 AM > > To: Mrzyglod, DanielX T; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2 4/6] i40e: add additional ieee1588 su= pport > > functions > > > > Hi Daniel, > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Daniel Mrzyglod > > > Sent: Friday, October 30, 2015 9:43 AM > > > To: dev@dpdk.org > > > Subject: [dpdk-dev] [PATCH v2 4/6] i40e: add additional ieee1588 supp= ort > > functions > > > > > > From: Pablo de Lara > > > > > > Add additional functions to support the existing IEEE1588 > > > functionality and to enable getting, setting and adjusting > > > the device time. > > > > > > Signed-off-by: Pablo de Lara > > > Signed-off-by: Daniel Mrzyglod >=20 > [...] >=20 > > > > These 3 functions above are redefined for each PMD in your patch. > > I think it is worth to move it to the upper layer (rte_ethdev, rte_net)= to avoid > > code duplication. > > Thanks > > Kinstantin >=20 > We thought about that, but we didn't know what the best place was for the= m. > Looking at the functions in rte_ethdev, they look quite different compare= d to these ones, > so we thought it wasn't the appropriate place. Do you think that is the b= est place Inisde librte_net might be? They are sort of helper functions for PTP right? So might be create a librte_net/rte_ptp.h and put it here? Konstantin >=20 > Thanks, > Pablo