From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 35E9D8E58 for ; Thu, 10 Dec 2015 15:50:34 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 10 Dec 2015 06:50:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,408,1444719600"; d="scan'208";a="10963619" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga004.fm.intel.com with ESMTP; 10 Dec 2015 06:50:32 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.203]) by IRSMSX107.ger.corp.intel.com ([169.254.10.124]) with mapi id 14.03.0248.002; Thu, 10 Dec 2015 14:50:31 +0000 From: "Ananyev, Konstantin" To: "Iremonger, Bernard" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] examples/vhost: reduce number of hugepages needed Thread-Index: AQHRM1I9YVi6rEu33EyNdYAZaGYxAZ7ES/nA Date: Thu, 10 Dec 2015 14:50:31 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836AD25A2@irsmsx105.ger.corp.intel.com> References: <1449749971-5422-1-git-send-email-bernard.iremonger@intel.com> <1449755601-25670-1-git-send-email-bernard.iremonger@intel.com> In-Reply-To: <1449755601-25670-1-git-send-email-bernard.iremonger@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] examples/vhost: reduce number of hugepages needed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Dec 2015 14:50:34 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard Iremonger > Sent: Thursday, December 10, 2015 1:53 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] examples/vhost: reduce number of hugepages= needed >=20 > Change MAX_QUEUES from 512 to 128 to reduce the number of hugepages > required by the vhost-switch program. >=20 > Changes in v2: > remove comment added before #define MAX_QUEUES in v1 patch. >=20 > Signed-off-by: Bernard Iremonger > Acked-by: Yuanhan Liu Wasn't it increased a while ago, because someone complained that 128 queues might not be enough on FVL? >>From git log I can see that it was first increased from 128 to 256, then from 256 to 512. The reason mentioned - HW that has bigger number of queues.=20 Isn't it not the case anymore? If yes, why? BTW, shouldn't it be then at least: +#ifndef MAX_QUEUES +#define MAX_QUEUES 128 +#endif So people can just do -D MAX_QUEUES=3DX at build time if they like(need) to= . Konstantin > --- > examples/vhost/main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/examples/vhost/main.c b/examples/vhost/main.c > index b30f1bd..5ce5926 100644 > --- a/examples/vhost/main.c > +++ b/examples/vhost/main.c > @@ -1,7 +1,7 @@ > /*- > * BSD LICENSE > * > - * Copyright(c) 2010-2014 Intel Corporation. All rights reserved. > + * Copyright(c) 2010-2015 Intel Corporation. All rights reserved. > * All rights reserved. > * > * Redistribution and use in source and binary forms, with or without > @@ -53,7 +53,7 @@ >=20 > #include "main.h" >=20 > -#define MAX_QUEUES 512 > +#define MAX_QUEUES 128 >=20 > /* the maximum number of external ports supported */ > #define MAX_SUP_PORTS 1 > -- > 2.6.3