From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 6D1C28E72
 for <dev@dpdk.org>; Fri, 11 Dec 2015 15:42:43 +0100 (CET)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga102.jf.intel.com with ESMTP; 11 Dec 2015 06:42:12 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,414,1444719600"; d="scan'208";a="858836090"
Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157])
 by fmsmga001.fm.intel.com with ESMTP; 11 Dec 2015 06:42:12 -0800
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.203]) by
 IRSMSX103.ger.corp.intel.com ([169.254.3.13]) with mapi id 14.03.0248.002;
 Fri, 11 Dec 2015 14:42:08 +0000
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Thread-Topic: [dpdk-dev] [PATCH v2 4/4] cache/slow-path: reduce cache align
 requirement for 128-byte cache targets
Thread-Index: AQHRM2kbny3RKqmdSEuc+vidWbqPKZ7Ft4gwgAAZIoCAAAyAUA==
Date: Fri, 11 Dec 2015 14:42:08 +0000
Message-ID: <2601191342CEEE43887BDE71AB97725836AD2B53@irsmsx105.ger.corp.intel.com>
References: <1449417564-29600-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1449765378-29563-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1449765378-29563-5-git-send-email-jerin.jacob@caviumnetworks.com>
 <2601191342CEEE43887BDE71AB97725836AD2A79@irsmsx105.ger.corp.intel.com>
 <20151211135631.GA23152@localhost.localdomain>
In-Reply-To: <20151211135631.GA23152@localhost.localdomain>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 4/4] cache/slow-path: reduce cache align
 requirement for 128-byte cache targets
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Dec 2015 14:42:43 -0000


> >
> > I think we better keep both struct rte_ring_debug_stats and rte_mempool=
_debug_stats
> > as __rte_cache_aligned.
> > Both are on a  per core basis and can be used at run-time
> > (when RTE_LIBRTE_RING_DEBUG/RTE_LIBRTE_MEMPOOL_DEBUG=3Dy),
> > and not supposed to be shared by different cores.
> > All other things in the series look good to me.
>=20
> OK, I will fix the alignment of rte_ring_debug_stats and
> rte_mempool_debug_stats and send the next revision with your ACK.

Works for me.
Konstantin