From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Stephen Hemminger <shemming@brocade.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Zhang, Helin" <helin.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 ] ixgbe: speed up transmit
Date: Fri, 11 Dec 2015 18:52:36 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725836AD2DA5@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <20151211084819.2177795d@xeon-e3>
> -----Original Message-----
> From: Stephen Hemminger [mailto:shemming@brocade.com]
> Sent: Friday, December 11, 2015 4:48 PM
> To: dev@dpdk.org; Zhang, Helin; Ananyev, Konstantin
> Subject: Re: [PATCH v2 ] ixgbe: speed up transmit
>
> On Fri, 13 Nov 2015 08:10:13 -0800
> Stephen Hemminger <stephen@networkplumber.org> wrote:
>
> > From: Stephen Hemminger <shemming@brocade.com>
> >
> > The freeing of mbuf's in ixgbe is one of the observable hot spots
> > under load. Optimize it by doing bulk free of mbufs using code similar
> > to i40e and fm10k.
> >
> > Drop the no longer needed micro-optimization for the no refcount flag.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> How come this patch got no review or comments?
> It gets a visible performance gain of up to 10% in some cases.
>
> I understand maintainers are busy with internal work, but they need
> to read mailing list as well.
Yep, I missed it somehow.
BTW, by some reason I couldn't find it patchwork....
Was it submitted too late for 2.2 timeframe?
Anyway, about the patch itself: it looks good to me and indeed it provides 10%+
performance improvement.
So here is my ACK for it.
Konstantin
next prev parent reply other threads:[~2015-12-11 18:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 16:10 Stephen Hemminger
2015-12-11 16:48 ` Stephen Hemminger
2015-12-11 18:52 ` Ananyev, Konstantin [this message]
2016-02-10 15:19 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB97725836AD2DA5@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=shemming@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).