From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 89478374C
 for <dev@dpdk.org>; Fri, 11 Dec 2015 19:52:47 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga103.fm.intel.com with ESMTP; 11 Dec 2015 10:52:39 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,414,1444719600"; d="scan'208";a="871814725"
Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23])
 by fmsmga002.fm.intel.com with ESMTP; 11 Dec 2015 10:52:38 -0800
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.203]) by
 IRSMSX109.ger.corp.intel.com ([169.254.13.96]) with mapi id 14.03.0248.002;
 Fri, 11 Dec 2015 18:52:37 +0000
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Stephen Hemminger <shemming@brocade.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "Zhang, Helin" <helin.zhang@intel.com>
Thread-Topic: [PATCH v2 ] ixgbe: speed up transmit
Thread-Index: AQHRNDPDKBebZA0dVkizVBpCIrBbk57GHcHQ
Date: Fri, 11 Dec 2015 18:52:36 +0000
Message-ID: <2601191342CEEE43887BDE71AB97725836AD2DA5@irsmsx105.ger.corp.intel.com>
References: <1447431013-23245-1-git-send-email-stephen@networkplumber.org>
 <20151211084819.2177795d@xeon-e3>
In-Reply-To: <20151211084819.2177795d@xeon-e3>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 ] ixgbe: speed up transmit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Dec 2015 18:52:47 -0000

> -----Original Message-----
> From: Stephen Hemminger [mailto:shemming@brocade.com]
> Sent: Friday, December 11, 2015 4:48 PM
> To: dev@dpdk.org; Zhang, Helin; Ananyev, Konstantin
> Subject: Re: [PATCH v2 ] ixgbe: speed up transmit
>=20
> On Fri, 13 Nov 2015 08:10:13 -0800
> Stephen Hemminger <stephen@networkplumber.org> wrote:
>=20
> > From: Stephen Hemminger <shemming@brocade.com>
> >
> > The freeing of mbuf's in ixgbe is one of the observable hot spots
> > under load. Optimize it by doing bulk free of mbufs using code similar
> > to i40e and fm10k.
> >
> > Drop the no longer needed micro-optimization for the no refcount flag.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>=20
> How come this patch got no review or comments?
> It gets a visible performance gain of up to 10% in some cases.
>=20
> I understand maintainers are busy with internal work, but they need
> to read mailing list as well.

Yep, I missed it somehow.
BTW, by some reason I couldn't find it patchwork....
Was it submitted too late for 2.2 timeframe?
Anyway, about the patch itself: it looks good to me and indeed it provides =
10%+
performance improvement.
So here is my ACK for it.
Konstantin