From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B4CBB2965 for ; Wed, 9 Mar 2016 14:17:16 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 09 Mar 2016 05:17:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,311,1455004800"; d="scan'208";a="920156778" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga001.fm.intel.com with ESMTP; 09 Mar 2016 05:17:15 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.35]) by IRSMSX107.ger.corp.intel.com ([169.254.10.137]) with mapi id 14.03.0248.002; Wed, 9 Mar 2016 13:17:14 +0000 From: "Ananyev, Konstantin" To: "Iremonger, Bernard" , "dev@dpdk.org" Thread-Topic: [PATCH v4 3/3] ixgbe: fix dev_close to remove VF MAC address. Thread-Index: AQHReV19H5yh63xQ+kidM27oGzyhW59RGOFw Date: Wed, 9 Mar 2016 13:17:13 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836B1A457@irsmsx105.ger.corp.intel.com> References: <1457372306-1746-1-git-send-email-bernard.iremonger@intel.com> <1457457027-21419-1-git-send-email-bernard.iremonger@intel.com> <1457457027-21419-4-git-send-email-bernard.iremonger@intel.com> In-Reply-To: <1457457027-21419-4-git-send-email-bernard.iremonger@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDBmMTRhOTktNWQ0OC00NWY4LThjZmYtY2U0ZDU3YjQ5ZTEzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InpRaEU5RTZhK0NcLzlKUEwxVjJweUtIZ2p6VWEwTlwvY1J3aWdmV21YeFVnYz0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 3/3] ixgbe: fix dev_close to remove VF MAC address. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2016 13:17:17 -0000 > -----Original Message----- > From: Iremonger, Bernard > Sent: Tuesday, March 08, 2016 5:10 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin; Lu, Wenzhuo; Wu, Jingjing; Iremonger, Bernard > Subject: [PATCH v4 3/3] ixgbe: fix dev_close to remove VF MAC address. >=20 > Call the ixgbevf_remove_mac_addr() function in the ixgbevf_dev_close() > function to ensure that the VF traffic goes to the PF after stop, > close and detach of the VF. >=20 > Fixes: af75078fece3 ("first public release") > Signed-off-by: Bernard Iremonger > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_e= thdev.c > index 759177a..96b42f8 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -3911,8 +3911,12 @@ ixgbevf_dev_close(struct rte_eth_dev *dev) >=20 > ixgbe_dev_free_queues(dev); >=20 > - /* reprogram the RAR[0] in case user changed it. */ > - ixgbe_set_rar(hw, 0, hw->mac.addr, 0, IXGBE_RAH_AV); > + /** > + * Remove the VF MAC address ro ensure > + * that the VF traffic goes to the PF > + * after stop, close and detach of the VF > + **/ > + ixgbevf_remove_mac_addr(dev, 0); > } >=20 > static void ixgbevf_set_vfta_all(struct rte_eth_dev *dev, bool on) > -- Acked-by: Konstantin Ananyev > 2.6.3