From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id E2C4C2904
 for <dev@dpdk.org>; Thu, 24 Mar 2016 18:47:24 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga103.fm.intel.com with ESMTP; 24 Mar 2016 10:47:23 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,386,1455004800"; d="scan'208";a="675103442"
Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59])
 by FMSMGA003.fm.intel.com with ESMTP; 24 Mar 2016 10:47:24 -0700
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.35]) by
 IRSMSX151.ger.corp.intel.com ([169.254.4.72]) with mapi id 14.03.0248.002;
 Thu, 24 Mar 2016 17:47:22 +0000
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: Stephen Hemminger <stephen@networkplumber.org>
Thread-Topic: [PATCH v2] ixgbe: disable icc compile warning
Thread-Index: AQHRhfOEtOWWBZpPTUGeYnnYW8372p9o3fxw
Date: Thu, 24 Mar 2016 17:47:21 +0000
Message-ID: <2601191342CEEE43887BDE71AB97725836B20DA4@irsmsx105.ger.corp.intel.com>
References: <56F30A0C.5010207@intel.com>
 <1458840891-30237-1-git-send-email-ferruh.yigit@intel.com>
In-Reply-To: <1458840891-30237-1-git-send-email-ferruh.yigit@intel.com>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDZjNTAzNGMtMjA3MC00ZGU0LTlmMWItMmE3MTBjZjUzNzc0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InJReFZxZm9aQzZBZGFEbmNZSWRLeXgxZDFxem1cLzE5TEs2d2tqK0Joa093PSJ9
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: disable icc compile warning
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Mar 2016 17:47:25 -0000

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Thursday, March 24, 2016 5:35 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger; Ananyev, Konstantin; Yigit, Ferruh
> Subject: [PATCH v2] ixgbe: disable icc compile warning
>=20
> icc (icc (ICC) 16.0.1 20151021) is generating following compile error:
> "
>   CC ixgbe_rxtx.o
>   .../drivers/net/ixgbe/ixgbe_rxtx.c(153): error #3656: variable
>   "free" may be used before its value is set
>                       (nb_free > 0 && m->pool !=3D free[0]->pool)) {
> 			                         ^
> "
>=20
> Indeed this is a false positive and code is correct.
> "nb_free" check prevents the free[] access before its value set.
>=20
> Disabling this icc warning (#3656) for file ixgbe_rxtx.c.
>=20
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  drivers/net/ixgbe/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
> index c032775..50bf51c 100644
> --- a/drivers/net/ixgbe/Makefile
> +++ b/drivers/net/ixgbe/Makefile
> @@ -49,6 +49,8 @@ ifeq ($(CC), icc)
>  #
>  CFLAGS_BASE_DRIVER =3D -wd174 -wd593 -wd869 -wd981 -wd2259
>=20
> +CFLAGS_ixgbe_rxtx.o +=3D -wd3656
> +
>  else ifeq ($(CC), clang)
>  #
>  # CFLAGS for clang
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 2.5.0