From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 5D1CA2C4F for ; Thu, 31 Mar 2016 09:29:59 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 31 Mar 2016 00:29:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,421,1455004800"; d="scan'208";a="678437585" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by FMSMGA003.fm.intel.com with ESMTP; 31 Mar 2016 00:29:57 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.35]) by IRSMSX104.ger.corp.intel.com ([169.254.5.87]) with mapi id 14.03.0248.002; Thu, 31 Mar 2016 08:29:50 +0100 From: "Ananyev, Konstantin" To: "Lu, Wenzhuo" , "dev@dpdk.org" CC: "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] [PATCH] igb: change default RX wthresh back Thread-Index: AQHRixVUdSwReAwAn0SxRXPIrEzHlp9zJBBg Date: Thu, 31 Mar 2016 07:29:50 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836B22B5F@irsmsx105.ger.corp.intel.com> References: <1459405129-12442-1-git-send-email-wenzhuo.lu@intel.com> In-Reply-To: <1459405129-12442-1-git-send-email-wenzhuo.lu@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmIzOWE5YzctNDM2Mi00Y2YyLWE5NWMtNWYxNjIzMzViNWMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlJ4YklxRG9zVXJJUDFPZEhBdTY1MXorK0FsbTdLbHFqc0NwQzg2YTF6aVk9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] igb: change default RX wthresh back X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2016 07:29:59 -0000 Hi Wenzhuo, >=20 > A problem is found on i350 VF. TX will happen once per 4 > packets. If only 1~3 packets are received, they will not be > forwarded. >=20 > The reason is the default RX write-back threshold is changed > to 4. This patch changes the value back to 0, so every packet > can be handled immediately. >=20 > Fixes: 4a41c17dba18 (igb: set default thresholds based on MAC type) > Signed-off-by: Wenzhuo Lu > --- > drivers/net/e1000/igb_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethde= v.c > index bd0ae26..34120ae 100644 > --- a/drivers/net/e1000/igb_ethdev.c > +++ b/drivers/net/e1000/igb_ethdev.c > @@ -64,7 +64,7 @@ >=20 > #define IGB_DEFAULT_RX_PTHRESH ((hw->mac.type =3D=3D e1000_i354) ? = 12 : 8) > #define IGB_DEFAULT_RX_HTHRESH 8 > -#define IGB_DEFAULT_RX_WTHRESH ((hw->mac.type =3D=3D e1000_82576) ?= 1 : 4) > +#define IGB_DEFAULT_RX_WTHRESH 0 But that still doesn't prevent user from setting wthresh to whatever he lik= es inside rx_queue_setup(), so the problem persists right? As a side notice, it seems really bad practice to use implicit variables in= side macro definition.=20 Konstantin >=20 > #define IGB_DEFAULT_TX_PTHRESH ((hw->mac.type =3D=3D e1000_i354) ? = 20 : 8) > #define IGB_DEFAULT_TX_HTHRESH 1 > -- > 1.9.3