From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id BD06F8DB3 for ; Thu, 31 Mar 2016 15:53:37 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 31 Mar 2016 06:52:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,422,1455004800"; d="scan'208";a="678597856" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by FMSMGA003.fm.intel.com with ESMTP; 31 Mar 2016 06:52:47 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.35]) by IRSMSX107.ger.corp.intel.com ([169.254.10.137]) with mapi id 14.03.0248.002; Thu, 31 Mar 2016 14:52:45 +0100 From: "Ananyev, Konstantin" To: "Kulasek, TomaszX" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] examples/l3fwd: fix some packets lost when stops receiving Thread-Index: AQHRi1KhxSI6K29R1kOSoPGdhNj+CZ9zkdPg Date: Thu, 31 Mar 2016 13:52:44 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836B22E89@irsmsx105.ger.corp.intel.com> References: <1459431488-5408-1-git-send-email-tomaszx.kulasek@intel.com> In-Reply-To: <1459431488-5408-1-git-send-email-tomaszx.kulasek@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzhiYTcxOWItNjdkMy00OWJlLTkxZTQtNmE1MWJlZDhhOGFiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlBwZzc2XC9ITnd0M2kybm5BNFU0SGQ3aGlMd21LSW0zZWRnWjlnb0Z3Qjg0PSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix some packets lost when stops receiving X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2016 13:53:38 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Kulasek > Sent: Thursday, March 31, 2016 2:38 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] examples/l3fwd: fix some packets lost when st= ops receiving >=20 > Not all tx ports was included in tx_port_id array, used to periodically > drain only available ports. This caused that some packets remain in buffe= r > when application stops to receiving packets. >=20 > Fixes: 52c97adc1f0f ("examples/l3fwd: fix exact match performance") >=20 > Signed-off-by: Tomasz Kulasek > --- > examples/l3fwd/main.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) >=20 > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c > index e10dab9..92fda3b 100644 > --- a/examples/l3fwd/main.c > +++ b/examples/l3fwd/main.c > @@ -836,7 +836,6 @@ main(int argc, char **argv) > unsigned lcore_id; > uint32_t n_tx_queue, nb_lcores; > uint8_t portid, nb_rx_queue, queue, socketid; > - uint8_t nb_tx_port; >=20 > /* init EAL */ > ret =3D rte_eal_init(argc, argv); > @@ -876,7 +875,6 @@ main(int argc, char **argv) > rte_exit(EXIT_FAILURE, "check_port_config failed\n"); >=20 > nb_lcores =3D rte_lcore_count(); > - nb_tx_port =3D 0; >=20 > /* Setup function pointers for lookup method. */ > setup_l3fwd_lookup_tables(); > @@ -954,12 +952,10 @@ main(int argc, char **argv) > qconf->tx_queue_id[portid] =3D queueid; > queueid++; >=20 > - qconf->n_tx_port =3D nb_tx_port; > qconf->tx_port_id[qconf->n_tx_port] =3D portid; > + qconf->n_tx_port++; > } > printf("\n"); > - > - nb_tx_port++; > } >=20 > for (lcore_id =3D 0; lcore_id < RTE_MAX_LCORE; lcore_id++) { > -- Acked-by: Konstantin Ananyev > 1.7.9.5