From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Mrzyglod, DanielX T" <danielx.t.mrzyglod@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/test_acl: fix division by float zero
Date: Fri, 22 Apr 2016 15:15:08 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725836B40DA5@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1461340850-202703-1-git-send-email-danielx.t.mrzyglod@intel.com>
> -----Original Message-----
> From: Mrzyglod, DanielX T
> Sent: Friday, April 22, 2016 5:01 PM
> To: Ananyev, Konstantin
> Cc: dev@dpdk.org; Mrzyglod, DanielX T
> Subject: [PATCH] app/test_acl: fix division by float zero
>
> Fix issue reported by Coverity.
> Coverity ID 13240
>
> This could cause an immediate crash or incorrect computation.
>
> In search_ip5tuples: An expression which may be zero is used
> as a divisor in floating-point arithmetic.
>
> divide_by_zero: In expression (long double)tm / pkt,
> division by expression pkt which may be zero has undefined behavior.
>
> Fixes: 26c057ab6c45 ("acl: new test-acl application")
>
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> ---
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
next prev parent reply other threads:[~2016-04-22 15:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 16:00 Daniel Mrzyglod
2016-04-22 15:15 ` Ananyev, Konstantin [this message]
2016-04-27 14:14 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB97725836B40DA5@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=danielx.t.mrzyglod@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).