From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 91F532BD1 for ; Fri, 22 Apr 2016 17:15:13 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 22 Apr 2016 08:15:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,517,1455004800"; d="scan'208";a="964359152" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga002.fm.intel.com with ESMTP; 22 Apr 2016 08:15:10 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.35]) by IRSMSX108.ger.corp.intel.com ([169.254.11.238]) with mapi id 14.03.0248.002; Fri, 22 Apr 2016 16:15:08 +0100 From: "Ananyev, Konstantin" To: "Mrzyglod, DanielX T" CC: "dev@dpdk.org" Thread-Topic: [PATCH] app/test_acl: fix division by float zero Thread-Index: AQHRnKdt2Ak6VCSY40aquZ/syb0kqJ+WGgSQ Date: Fri, 22 Apr 2016 15:15:08 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836B40DA5@irsmsx105.ger.corp.intel.com> References: <1461340850-202703-1-git-send-email-danielx.t.mrzyglod@intel.com> In-Reply-To: <1461340850-202703-1-git-send-email-danielx.t.mrzyglod@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDA2MGM5ZTctMGFmYy00ODAzLTk0ODQtYTg0ZDRkZjQ1Y2FiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjJwNDhZc3F5clVXUndob0lVTjBwc2l0aW1MUDlERjhXVnBlaUhwN1crQTA9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/test_acl: fix division by float zero X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2016 15:15:14 -0000 > -----Original Message----- > From: Mrzyglod, DanielX T > Sent: Friday, April 22, 2016 5:01 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; Mrzyglod, DanielX T > Subject: [PATCH] app/test_acl: fix division by float zero >=20 > Fix issue reported by Coverity. > Coverity ID 13240 >=20 > This could cause an immediate crash or incorrect computation. >=20 > In search_ip5tuples: An expression which may be zero is used > as a divisor in floating-point arithmetic. >=20 > divide_by_zero: In expression (long double)tm / pkt, > division by expression pkt which may be zero has undefined behavior. >=20 > Fixes: 26c057ab6c45 ("acl: new test-acl application") >=20 > Signed-off-by: Daniel Mrzyglod > --- Acked-by: Konstantin Ananyev