From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id B82D69604 for ; Wed, 8 Jun 2016 10:38:06 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 08 Jun 2016 01:38:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,438,1459839600"; d="scan'208";a="997628224" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga002.fm.intel.com with ESMTP; 08 Jun 2016 01:38:05 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.51]) by IRSMSX108.ger.corp.intel.com ([169.254.11.183]) with mapi id 14.03.0248.002; Wed, 8 Jun 2016 09:37:50 +0100 From: "Ananyev, Konstantin" To: "Lu, Wenzhuo" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] examples: add a new example for link reset Thread-Index: AQHRv7crPDbbDxXhKEe6mCFtk4nOaJ/et9/wgABlgQCAACQ7EA== Date: Wed, 8 Jun 2016 08:37:50 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836B6CC85@irsmsx105.ger.corp.intel.com> References: <1465192093-28651-1-git-send-email-wenzhuo.lu@intel.com> <1465192093-28651-2-git-send-email-wenzhuo.lu@intel.com> <2601191342CEEE43887BDE71AB97725836B6CBA3@irsmsx105.ger.corp.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC090903483A48@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC090903483A48@shsmsx102.ccr.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples: add a new example for link reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2016 08:38:07 -0000 Hi Wenzhuo, =20 > Hi Konstantin, >=20 > > -----Original Message----- > > From: Ananyev, Konstantin > > Sent: Wednesday, June 8, 2016 8:25 AM > > To: Lu, Wenzhuo; dev@dpdk.org > > Cc: Lu, Wenzhuo > > Subject: RE: [dpdk-dev] [PATCH] examples: add a new example for link re= set > > > > > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > > > Sent: Monday, June 06, 2016 6:48 AM > > > To: dev@dpdk.org > > > Cc: Lu, Wenzhuo > > > Subject: [dpdk-dev] [PATCH] examples: add a new example for link rese= t > > > > > > Add a new example to show when the PF is down and up, VF port can be > > > reset and recover. > > > > Do we really need a totally new example for it? > > Can't we put it in one of already existing ones? > > Let say we have l3fwd-vf... wouldn't that suit your needs? > > Konstantin > I thought about just modifying an existing example. But I choose to add a= new one at last. The benefit of a totally new example is we > can make it simple enough and focus on the reset function. > So it's easier for the users to find what we want to show. And it's also = easier for us as we don't need to care about if our modification > will break some function of the original example :) I still think that adding a new example for esch new feature/function in rt= e_ethdev API iw way too expensive. If your change is not good enough and will break original example, then you= probably re-work your feature patch to make it stable enough. After all people will use it in their existing apps, not write the new ones= right? BTW, why not make it work with testpmd? After all it is a new PMD api, an that's for we have our testpmd here? Konstantin=20