From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id B7C542986
 for <dev@dpdk.org>; Thu, 30 Jun 2016 14:14:10 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga102.fm.intel.com with ESMTP; 30 Jun 2016 05:14:10 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,552,1459839600"; d="scan'208";a="837976697"
Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75])
 by orsmga003.jf.intel.com with ESMTP; 30 Jun 2016 05:14:10 -0700
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.51]) by
 IRSMSX153.ger.corp.intel.com ([169.254.9.105]) with mapi id 14.03.0248.002;
 Thu, 30 Jun 2016 13:14:07 +0100
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH] mk: fix acl library static linking
Thread-Index: AQHR0sANMuMUF1qLPE+AgoJTRKElPqAB7BzA
Date: Thu, 30 Jun 2016 12:14:07 +0000
Message-ID: <2601191342CEEE43887BDE71AB97725836B784B9@irsmsx105.ger.corp.intel.com>
References: <1467285021-103920-1-git-send-email-sergio.gonzalez.monroy@intel.com>
In-Reply-To: <1467285021-103920-1-git-send-email-sergio.gonzalez.monroy@intel.com>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] mk: fix acl library static linking
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jun 2016 12:14:11 -0000



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergio Gonzalez Monr=
oy
> Sent: Thursday, June 30, 2016 12:10 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] mk: fix acl library static linking
>=20
> Since below commit, ACL library is outside the scope of --whole-archive
> and ACL autotest fails.
>=20
>   RTE>>acl_autotest
>   ACL: allocation of 25166728 bytes on socket 9 for ACL_acl_ctx failed
>   ACL: rte_acl_add_rules(acl_ctx): rule #1 is invalid
>   Line 1584: SSE classify with zero categories failed!
>   Test Failed
>=20
> This is the result of the linker picking weak over non-weak functions.
>=20
> Fixes: 95dc3c3cf31c ("mk: reduce scope of whole-archive static linking")
>=20
> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
> ---
>  mk/rte.app.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> index 83314ca..7f89fd4 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -76,12 +76,12 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_IP_FRAG)        +=3D -lrt=
e_ip_frag
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_METER)          +=3D -lrte_meter
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_SCHED)          +=3D -lrte_sched
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_LPM)            +=3D -lrte_lpm
> -_LDLIBS-$(CONFIG_RTE_LIBRTE_ACL)            +=3D -lrte_acl
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_JOBSTATS)       +=3D -lrte_jobstats
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_POWER)          +=3D -lrte_power
>=20
>  _LDLIBS-y +=3D --whole-archive
>=20
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_ACL)            +=3D -lrte_acl
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER)          +=3D -lrte_timer
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_HASH)           +=3D -lrte_hash
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST)          +=3D -lrte_vhost
> --
> 2.4.11

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>