From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1F5A92C30 for ; Thu, 30 Jun 2016 17:24:53 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 30 Jun 2016 08:24:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,552,1459839600"; d="scan'208";a="998128557" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga001.fm.intel.com with ESMTP; 30 Jun 2016 08:24:52 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.51]) by IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0248.002; Thu, 30 Jun 2016 16:24:51 +0100 From: "Ananyev, Konstantin" To: "Gonzalez Monroy, Sergio" , "Thomas Monjalon" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] mk: fix acl library static linking Thread-Index: AQHR0sANMuMUF1qLPE+AgoJTRKElPqAB0X6AgAAHVgCAAAsyAIAAFbmAgAAmyQA= Date: Thu, 30 Jun 2016 15:24:50 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836B78610@irsmsx105.ger.corp.intel.com> References: <1467285021-103920-1-git-send-email-sergio.gonzalez.monroy@intel.com> <5547616.scaE5dMnT7@xps13> <1776198.xo6Bm4C5fO@xps13> <2994f200-70c4-3fe2-5976-fc1799271430@intel.com> In-Reply-To: <2994f200-70c4-3fe2-5976-fc1799271430@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] mk: fix acl library static linking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2016 15:24:54 -0000 Hi Thomas, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergio Gonzalez Monr= oy > Sent: Thursday, June 30, 2016 3:02 PM > To: Thomas Monjalon > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] mk: fix acl library static linking >=20 > On 30/06/2016 13:44, Thomas Monjalon wrote: > > 2016-06-30 13:04, Sergio Gonzalez Monroy: > >> On 30/06/2016 12:38, Thomas Monjalon wrote: > >>> Does it need to be commented in rte.app.mk? > >>> The other libs are in whole-archive to support dlopen of drivers. > >>> But the problem here is not because of a driver use. > >> There seem to be a bunch of libraries under --whole-archive scope that > >> are not > >> PMDs, ie. cfgfile, cmdline... > >> > >> What is the criteria? > > The criteria is a bit vague. We must try to include only libs which can > > be used by a driver. > > cmdline should probably not be there. > > Does it make sense to use cfgfile in a driver? maybe yes. >=20 > So as it is, ACL autotest is broken when building static libs > (non-combined). > For combined libs we usually wrap libdpdk.a with --whole-archive, thus it= is > not an issue. >=20 > Just thinking a bit more about the 'dlopen of drivers' case you > mentioned before, > shouldn't the driver have proper dependencies and therefore need shared > DPDK libraries? > What does happen if binary/app and driver are built against different > library versions? > Where does it say that we do support this use case? >=20 > Sergio >=20 So are you going to apply this patch? Right now acl just can't be used properly in case of static library build. Thanks Konstantin