From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <konstantin.ananyev@intel.com> Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 6ACBB2BBD for <dev@dpdk.org>; Mon, 11 Jul 2016 10:18:40 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP; 11 Jul 2016 01:18:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,345,1464678000"; d="scan'208";a="1014413675" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga002.jf.intel.com with ESMTP; 11 Jul 2016 01:18:39 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.51]) by IRSMSX153.ger.corp.intel.com ([169.254.9.105]) with mapi id 14.03.0248.002; Mon, 11 Jul 2016 09:18:37 +0100 From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com> To: Thomas Monjalon <thomas.monjalon@6wind.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com> CC: "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup Thread-Index: AQHR2zyQoa7N6FxX7EC8l93zLOeGLaASv5aAgAAfmiA= Date: Mon, 11 Jul 2016 08:18:37 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836B7C73C@irsmsx105.ger.corp.intel.com> References: <1468218079-8064-1-git-send-email-wenzhuo.lu@intel.com> <2092181.9Q4Kasxdod@xps13> In-Reply-To: <2092181.9Q4Kasxdod@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 11 Jul 2016 08:18:40 -0000 Hi Thomas, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Monday, July 11, 2016 8:11 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup >=20 > 2016-07-11 14:21, Wenzhuo Lu: > > In testpmd code, device id is used directly to check if bypass > > is supported. But APP should not know the details of HW, the NIC > > specific info should not be exposed here. >=20 > Right >=20 > > This patch adds a new rte API to check if bypass is supported. >=20 > Hmmm. It's true it is cleaner. But I am not sure having a generic API > for bypass is a good idea at all. > I was thinking to totally remove it. Why to remove it? As I know there are people who use that functionality. > Maybe we can try to have a specific API by including ixgbe_bypass.h in > the application. Hmm, isn't that what we were trying to get rid of in last few years? HW specific stuff? Konstantin =20