From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 30AF9370 for ; Wed, 20 Jul 2016 17:13:36 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 20 Jul 2016 08:13:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,394,1464678000"; d="scan'208";a="999109788" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga001.jf.intel.com with ESMTP; 20 Jul 2016 08:13:33 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.51]) by IRSMSX107.ger.corp.intel.com ([169.254.10.204]) with mapi id 14.03.0248.002; Wed, 20 Jul 2016 16:13:32 +0100 From: "Ananyev, Konstantin" To: Thomas Monjalon , "Kulasek, TomaszX" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] doc: announce ABI change for rte_eth_dev structure Thread-Index: AQHR4pNNqjJ+FF1dqkWP4s8ubTgyhqAhWTCAgAATI1A= Date: Wed, 20 Jul 2016 15:13:32 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836B7FFB6@irsmsx105.ger.corp.intel.com> References: <1469024691-58750-1-git-send-email-tomaszx.kulasek@intel.com> <2192482.DY91PqGyRQ@xps13> In-Reply-To: <2192482.DY91PqGyRQ@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for rte_eth_dev structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2016 15:13:36 -0000 Hi Thomas, > Hi, >=20 > This patch announces an interesting change in the DPDK design. >=20 > 2016-07-20 16:24, Tomasz Kulasek: > > This is an ABI deprecation notice for DPDK 16.11 in librte_ether about > > changes in rte_eth_dev and rte_eth_desc_lim structures. > > > > In 16.11, we plan to introduce rte_eth_tx_prep() function to do > > necessary preparations of packet burst to be safely transmitted on > > device for desired HW offloads (set/reset checksum field according to > > the hardware requirements) and check HW constraints (number of > > segments per packet, etc). > > > > While the limitations and requirements may differ for devices, it > > requires to extend rte_eth_dev structure with new function pointer > > "tx_pkt_prep" which can be implemented in the driver to prepare and > > verify packets, in devices specific way, before burst, what should to > > prevent application to send malformed packets. > > > > Also new fields will be introduced in rte_eth_desc_lim: nb_seg_max and > > nb_mtu_seg_max, providing an information about max segments in TSO and > > non TSO packets acceptable by device. >=20 > We cannot acknowledge such notice without a prior design discussion. > Please explain why you plan to work on this change and give a draft of th= e new structures (a RFC patch would be ideal). I think it is not really a deprecation note, but announce ABI change for rt= e_ethdev.h structures. The plan is to implement what was proposed & discussed the following thread= : http://dpdk.org/ml/archives/dev/2015-September/023603.html Konstantin