From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 25DE1530A for ; Wed, 27 Jul 2016 19:33:04 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP; 27 Jul 2016 10:33:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,430,1464678000"; d="scan'208";a="146432104" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga004.fm.intel.com with ESMTP; 27 Jul 2016 10:33:03 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.102]) by IRSMSX152.ger.corp.intel.com ([169.254.6.43]) with mapi id 14.03.0248.002; Wed, 27 Jul 2016 18:33:02 +0100 From: "Ananyev, Konstantin" To: Jerin Jacob , Thomas Monjalon CC: "Kulasek, TomaszX" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] doc: announce ABI change for rte_eth_dev structure Thread-Index: AQHR42Ph+H7D9jswiE+CcJzq4idrzqAjfOLAgAh1z4CAAIljgIAAFeJg Date: Wed, 27 Jul 2016 17:33:01 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836B8884E@irsmsx105.ger.corp.intel.com> References: <1469024691-58750-1-git-send-email-tomaszx.kulasek@intel.com> <1469114659-66063-1-git-send-email-tomaszx.kulasek@intel.com> <2601191342CEEE43887BDE71AB97725836B80AD8@irsmsx105.ger.corp.intel.com> <2146153.nVzdynOqdk@xps13> <20160727171043.GA22116@localhost.localdomain> In-Reply-To: <20160727171043.GA22116@localhost.localdomain> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] doc: announce ABI change for rte_eth_dev structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jul 2016 17:33:05 -0000 > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Wednesday, July 27, 2016 6:11 PM > To: Thomas Monjalon > Cc: Kulasek, TomaszX ; dev@dpdk.org; Ananyev, = Konstantin > Subject: Re: [dpdk-dev] [PATCH v2] doc: announce ABI change for rte_eth_d= ev structure >=20 > On Wed, Jul 27, 2016 at 01:59:01AM -0700, Thomas Monjalon wrote: > > > > Signed-off-by: Tomasz Kulasek > > > > --- > > > > +* In 16.11 ABI changes are plained: the ``rte_eth_dev`` structure > > > > +will be > > > > + extended with new function pointer ``tx_pkt_prep`` allowing > > > > +verification > > > > + and processing of packet burst to meet HW specific requirements > > > > +before > > > > + transmit. Also new fields will be added to the ``rte_eth_desc_li= m`` structure: > > > > + ``nb_seg_max`` and ``nb_mtu_seg_max`` provideing information > > > > +about number of > > > > + segments limit to be transmitted by device for TSO/non-TSO packe= ts. > > > > > > Acked-by: Konstantin Ananyev > > > > I think I understand you want to split the TX processing: > > 1/ modify/write in mbufs > > 2/ write in HW > > and let application decide: > > - where the TX prep is done (which core) >=20 > In what basics applications knows when and where to call tx_pkt_prep in f= ast path. > if all the time it needs to call before tx_burst then the PMD won't have/= don't need this callback waste cycles in fast path.Is this the expected > behavior ? > Anything think it as compile time to make other PMDs wont suffer because = of this change. Not sure what suffering you are talking about... Current model - i.e. when application does preparations (or doesn't if none= is required) on its own and just call tx_burst() would still be there. If the app doesn't want to use tx_prep() by some reason - that still ok, and decision is up to the particular app.=20 Konstantin >=20 >=20 > > - what to do if the TX prep fail > > So adding some processing in this first part becomes "not too > > expensive" or "manageable" from the application point of view. > > > > If I well understand the intent, > > > > Acked-by: Thomas Monjalon (except typos ;)