From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Linzhe Lee <slayercat.subscription@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mbuf: fix atomic refcnt update synchronization
Date: Sat, 3 Sep 2016 22:52:07 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725836BA0851@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <CAK_yBkOtSNXL6=mD8eQRcFhjQ=HioD=FP5v2_nfZkwiuxfdoEg@mail.gmail.com>
Hi,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Linzhe Lee
> Sent: Saturday, September 3, 2016 3:05 AM
> To: Stephen Hemminger <stephen@networkplumber.org>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] mbuf: fix atomic refcnt update synchronization
>
> yes,stephen.
>
> my config file here: http://pastebin.com/N0RKGArh
>
> 2016-09-03 0:51 GMT+08:00 Stephen Hemminger <stephen@networkplumber.org>:
> > On Sat, 3 Sep 2016 00:31:50 +0800
> > Linzhe Lee <slayercat.subscription@gmail.com> wrote:
> >
> >> Thanks for reply, Stephen.
> >>
> >>
> >>
> >> I'm in x86-64, my cpu is `Intel(R) Xeon(R) CPU E5-2620 v3 @ 2.40GHz`.
> >>
> >>
> >>
> >> When allocation mbuf in program1, and transfer it to program2 for
> >> free via ring, the program1 might meet assert in allocate mbuf sometimes.
> >> (`RTE_ASSERT(rte_mbuf_refcnt_read(m) == 0);`)
If you believe there is a problem inside rte_mbuf code,
please provide a test program to reproduce the issue.
So far, I personally don't see any issue in the rte_mbuf code.
Konstantin
> >>
> >>
> >>
> >> but when I using gdb to check it, the refcnt field of mbuf is already
> >> zero. so I believe the problem came from the cache line problem or
> >> incorrect optimization.
> >>
> >>
> >>
> >> When apply this patch, the problem seems solved. I'm submitting it
> >> for your comments.
> >
> > Are you sure you have REFCNT_ATOMIC set?
prev parent reply other threads:[~2016-09-03 22:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 5:25 lilinzhe
2016-09-02 16:12 ` Stephen Hemminger
2016-09-02 16:31 ` Linzhe Lee
2016-09-02 16:51 ` Stephen Hemminger
2016-09-03 2:05 ` Linzhe Lee
2016-09-03 22:52 ` Ananyev, Konstantin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB97725836BA0851@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=slayercat.subscription@gmail.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).