From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id B1B80379B for ; Tue, 20 Sep 2016 09:15:44 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP; 20 Sep 2016 00:15:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,366,1470726000"; d="scan'208";a="170872500" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga004.fm.intel.com with ESMTP; 20 Sep 2016 00:15:44 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.196]) by IRSMSX153.ger.corp.intel.com ([169.254.9.140]) with mapi id 14.03.0248.002; Tue, 20 Sep 2016 08:15:42 +0100 From: "Ananyev, Konstantin" To: "Kulasek, TomaszX" , "'dev@dpdk.org'" CC: "'jerin.jacob@caviumnetworks.com'" Thread-Topic: [dpdk-dev] [PATCH v2 5/6] ixgbe: add Tx preparation Thread-Index: AQHSDQU3U1SWwi8SuEaT8zAVcgeiOaCAy3FAgAAFeQCAACgyEIABCgdQ Date: Tue, 20 Sep 2016 07:15:41 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772583F0B7E21@irsmsx105.ger.corp.intel.com> References: <1472228578-6980-1-git-send-email-tomaszx.kulasek@intel.com> <1473691487-10032-1-git-send-email-tomaszx.kulasek@intel.com> <1473691487-10032-6-git-send-email-tomaszx.kulasek@intel.com> <2601191342CEEE43887BDE71AB9772583F0B5811@irsmsx105.ger.corp.intel.com> <3042915272161B4EB253DA4D77EB373A14F1923D@IRSMSX102.ger.corp.intel.com> <2601191342CEEE43887BDE71AB9772583F0B696C@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772583F0B696C@irsmsx105.ger.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 5/6] ixgbe: add Tx preparation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2016 07:15:45 -0000 > -----Original Message----- > From: Ananyev, Konstantin > Sent: Monday, September 19, 2016 4:24 PM > To: Kulasek, TomaszX ; dev@dpdk.org > Cc: jerin.jacob@caviumnetworks.com > Subject: RE: [dpdk-dev] [PATCH v2 5/6] ixgbe: add Tx preparation >=20 > > > > [...] > > > > > > > > > > ****************************************************************** > > > > ** > > > > ** / @@ -2290,6 +2369,7 @@ ixgbe_set_tx_function(struct > > > > rte_eth_dev *dev, struct ixgbe_tx_queue *txq) > > > > } else > > > > #endif > > > > dev->tx_pkt_burst =3D ixgbe_xmit_pkts_simple; > > > > + dev->tx_pkt_prep =3D ixgbe_prep_pkts_simple; > > > > > > Shouldn't we setup ixgbe_prep_pkts_simple when vTX is selected too? > > > > > > > > > It is, but source code is formatted like below: > > > > #ifdef RTE_IXGBE_INC_VECTOR > > if (txq->tx_rs_thresh <=3D RTE_IXGBE_TX_MAX_FREE_BUF_SZ && > > (rte_eal_process_type() !=3D RTE_PROC_PRIMARY || > > ixgbe_txq_vec_setup(txq) =3D=3D 0)) { > > PMD_INIT_LOG(DEBUG, "Vector tx enabled."); > > dev->tx_pkt_burst =3D ixgbe_xmit_pkts_vec; >=20 > Yep, so I thought we need a: > dev->tx_pkt_prep =3D ixgbe_prep_pkts_simple; > here too, no? Or if we decide, not to setup tx_pkt_prep at all for simple TX path - set NULL for both? But I think for both simple and vector TX the tx_prep value should be the s= ame. Konstantin >=20 > Konstantin >=20 >=20 > > } else > > #endif > > dev->tx_pkt_burst =3D ixgbe_xmit_pkts_simple; > > dev->tx_pkt_prep =3D ixgbe_prep_pkts_simple; > > > > > > > > } else { > > > > PMD_INIT_LOG(DEBUG, "Using full-featured tx code path"); > > > > PMD_INIT_LOG(DEBUG, > > > > @@ -2301,6 +2381,7 @@ ixgbe_set_tx_function(struct rte_eth_dev > > > > *dev, > > > struct ixgbe_tx_queue *txq) > > > > (unsigned long)txq->tx_rs_thresh, > > > > (unsigned long)RTE_PMD_IXGBE_TX_MAX_BURST); > > > > dev->tx_pkt_burst =3D ixgbe_xmit_pkts; > > > > + dev->tx_pkt_prep =3D ixgbe_prep_pkts; > > > > } > > > > } > > > > > > > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h > > > > b/drivers/net/ixgbe/ixgbe_rxtx.h index 2608b36..7bbd9b8 100644 > > > > --- a/drivers/net/ixgbe/ixgbe_rxtx.h > > > > +++ b/drivers/net/ixgbe/ixgbe_rxtx.h > > > > @@ -80,6 +80,8 @@ > > > > #define RTE_IXGBE_WAIT_100_US 100 > > > > #define RTE_IXGBE_VMTXSW_REGISTER_COUNT 2 > > > > > > > > +#define IXGBE_TX_MAX_SEG 40 > > > > + > > > > #define IXGBE_PACKET_TYPE_MASK_82599 0X7F > > > > #define IXGBE_PACKET_TYPE_MASK_X550 0X10FF > > > > #define IXGBE_PACKET_TYPE_MASK_TUNNEL 0XFF > > > > -- > > > > 1.7.9.5 > > > > Tomasz.