From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 5B93B2BA1 for ; Tue, 27 Sep 2016 19:25:59 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 27 Sep 2016 10:25:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,405,1470726000"; d="scan'208";a="1057349018" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga002.jf.intel.com with ESMTP; 27 Sep 2016 10:25:57 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.196]) by IRSMSX153.ger.corp.intel.com ([169.254.9.140]) with mapi id 14.03.0248.002; Tue, 27 Sep 2016 18:25:56 +0100 From: "Ananyev, Konstantin" To: "Tan, Jianfeng" , "dev@dpdk.org" CC: "Wu, Jingjing" Thread-Topic: [PATCH v5 3/3] app/testpmd: support tunneled TSO in csum fwd engine Thread-Index: AQHSF/yvga3oRMVGvUy/GFvutv5bbKCNmDWw Date: Tue, 27 Sep 2016 17:25:56 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772583F0BBE86@irsmsx105.ger.corp.intel.com> References: <1467752375-25984-1-git-send-email-zhe.tao@intel.com> <1474897714-28037-1-git-send-email-jianfeng.tan@intel.com> In-Reply-To: <1474897714-28037-1-git-send-email-jianfeng.tan@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 3/3] app/testpmd: support tunneled TSO in csum fwd engine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Sep 2016 17:25:59 -0000 > -----Original Message----- > From: Tan, Jianfeng > Sent: Monday, September 26, 2016 2:49 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Wu, Jingjing ; Tan, Jianfeng > ; Zhe Tao > Subject: [PATCH v5 3/3] app/testpmd: support tunneled TSO in csum fwd eng= ine >=20 > Add a new command "tunnel_tso set " to enable > segmentation offload and set MSS to tso_segsz. Another command, > "tunnel_tso show " is added to show tunneled packet MSS. > Result 0 means tunnel_tso is disabled. >=20 > The original commands, "tso set " and "tso show > " are only reponsible for non-tunneled packets. And the new > commands are for tunneled packets. >=20 > Below conditions are needed to make it work: > a. tunnel TSO is supported by the NIC; > b. "csum parse_tunnel" must be set so that tunneled pkts are > recognized; > c. for tunneled pkts with outer L3 is IPv4, "csum set outer-ip" > must be set to hw, because after tso, total_len of outer IP > header is changed, and the checksum of outer IP header calculated > by sw should be wrong; that is not necessary for IPv6 tunneled > pkts because there's no checksum field to be filled anymore. >=20 > Suggested-by: Konstantin Ananyev > Signed-off-by: Zhe Tao > Signed-off-by: Jianfeng Tan > --- > v5: > -- Instead of reuse original tso command, add a new command for > tunneled tso; > -- Fix a implicit conversion from long -> int bug, as the parameter > of process_outer_cksums() in previous version. > app/test-pmd/cmdline.c | 132 ++++++++++++++++++++++++++++++++++++++++++= +++--- > app/test-pmd/csumonly.c | 69 ++++++++++++++++++------- > app/test-pmd/testpmd.h | 3 +- > 3 files changed, 179 insertions(+), 25 deletions(-) >=20 Acked-by: Konstantin Ananyev