From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 283FE2B8C
 for <dev@dpdk.org>; Thu, 29 Sep 2016 19:01:13 +0200 (CEST)
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by fmsmga102.fm.intel.com with ESMTP; 29 Sep 2016 10:01:11 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,415,1473145200"; d="scan'208";a="14616491"
Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25])
 by fmsmga005.fm.intel.com with ESMTP; 29 Sep 2016 10:01:11 -0700
Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by
 irsmsx110.ger.corp.intel.com (163.33.3.25) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 29 Sep 2016 18:01:10 +0100
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.196]) by
 IRSMSX156.ger.corp.intel.com ([169.254.3.80]) with mapi id 14.03.0248.002;
 Thu, 29 Sep 2016 18:01:10 +0100
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Kulasek, TomaszX" <tomaszx.kulasek@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Thread-Topic: [PATCH v3 5/6] ixgbe: add Tx preparation
Thread-Index: AQHSGXlVFcTs+xMoc0KLIPgpiFTXj6CQTniggAA1mgCAAC7aEA==
Date: Thu, 29 Sep 2016 17:01:09 +0000
Message-ID: <2601191342CEEE43887BDE71AB9772583F0BCA72@irsmsx105.ger.corp.intel.com>
References: <1473691487-10032-1-git-send-email-tomaszx.kulasek@intel.com>
 <20160928111052.9968-1-tomaszx.kulasek@intel.com>
 <20160928111052.9968-6-tomaszx.kulasek@intel.com>
 <2601191342CEEE43887BDE71AB9772583F0BC604@irsmsx105.ger.corp.intel.com>
 <3042915272161B4EB253DA4D77EB373A14F33D37@IRSMSX102.ger.corp.intel.com>
In-Reply-To: <3042915272161B4EB253DA4D77EB373A14F33D37@IRSMSX102.ger.corp.intel.com>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v3 5/6] ixgbe: add Tx preparation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Sep 2016 17:01:13 -0000

I Tomasz,

> >
> > Just thought about it once again:
> > As now inside rte_eth_tx_prep() we do now:
> > +
> > +	if (!dev->tx_pkt_prep)
> > +		return nb_pkts;
> >
> > Then there might be a better approach to set
> > dev->tx_pkt_prep =3D NULL
> > for simple and vector TX functions?
> >
> > After all, prep_simple() does nothing but returns an error if
> > conditions are not met.
> > And if simple TX was already selected, then that means that user
> > deliberately disabled all HW TX offloads in favor of faster TX and
> > there is no point to slow him down with extra checks here.
> > Same for i40e and fm10k.
> > What is your opinion?
> >
> > Konstantin
> >
>=20
> Yes, if performance is a key, and, while the limitations of vector/simple=
 path are quite well documented, these additional checks are a
> bit overzealous. We may assume that to made tx offloads working, we need =
to configure driver in a right way, and this is a
> configuration issue if something doesn't work.
>=20
> I will remove it.

Great, thanks.
Konstantin