From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 90EB32BAC
 for <dev@dpdk.org>; Wed,  7 Dec 2016 11:13:30 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by fmsmga105.fm.intel.com with ESMTP; 07 Dec 2016 02:13:19 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,310,1477983600"; d="scan'208";a="199955187"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
 by fmsmga004.fm.intel.com with ESMTP; 07 Dec 2016 02:13:17 -0800
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.43]) by
 IRSMSX104.ger.corp.intel.com ([169.254.5.52]) with mapi id 14.03.0248.002;
 Wed, 7 Dec 2016 10:13:14 +0000
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>, "Yigit, Ferruh"
 <ferruh.yigit@intel.com>, Olivier Matz <olivier.matz@6wind.com>
CC: Thomas Monjalon <thomas.monjalon@6wind.com>, "dev@dpdk.org"
 <dev@dpdk.org>, Jan Medala <jan@semihalf.com>, Jakub Palider
 <jpa@semihalf.com>, Netanel Belgazal <netanel@amazon.com>, Evgeny Schemeilin
 <evgenys@amazon.com>, Alejandro Lucero <alejandro.lucero@netronome.com>, Yong
 Wang <yongwang@vmware.com>, Andrew Rybchenko <arybchenko@solarflare.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>, "Kulasek, TomaszX"
 <tomaszx.kulasek@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v12 0/6] add Tx preparation
Thread-Index: AQHSRbBDKacvBhx2eUCvrHI7LRX1L6DuQp0AgAzj2ACAARFCAIAAISvg
Date: Wed, 7 Dec 2016 10:13:14 +0000
Message-ID: <2601191342CEEE43887BDE71AB9772583F0E4E4B@irsmsx105.ger.corp.intel.com>
References: <1477486575-25148-1-git-send-email-tomaszx.kulasek@intel.com>
 <1479922585-8640-1-git-send-email-tomaszx.kulasek@intel.com>
 <8317180.L80Qf11uiu@xps13> <2dfc10d2-bb19-1385-aa01-97e44a3db139@intel.com>
 <20161207081144.GC31182@yliu-dev.sh.intel.com>
In-Reply-To: <20161207081144.GC31182@yliu-dev.sh.intel.com>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Dec 2016 10:13:31 -0000


Hi Yliu,

>=20
> On Tue, Dec 06, 2016 at 03:53:42PM +0000, Ferruh Yigit wrote:
> > > Please, we need a comment for each driver saying
> > > "it is OK, we do not need any checksum preparation for TSO"
> > > or
> > > "yes we have to implement tx_prepare or TSO will not work in this mod=
e"
> > >
>=20
> Sorry for late. For virtio, I think it's not a must. The checksum stuff
> has been handled inside the Tx function. However, we may could move it
> to tx_prepare, which would actually recover the performance lost
> introduced while enabling TSO for the non-TSO case.
>=20

So would you like to provide a patch for it,
Or would you like to keep tx_prepare() for virtio as NOP for now?
Thanks
Konstantin