From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 583072B96 for ; Wed, 7 Dec 2016 11:22:39 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 07 Dec 2016 02:22:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,310,1477983600"; d="scan'208";a="909616053" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga003.jf.intel.com with ESMTP; 07 Dec 2016 02:22:36 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.43]) by IRSMSX107.ger.corp.intel.com ([169.254.10.66]) with mapi id 14.03.0248.002; Wed, 7 Dec 2016 10:22:35 +0000 From: "Ananyev, Konstantin" To: Yuanhan Liu CC: "Yigit, Ferruh" , Olivier Matz , Thomas Monjalon , "dev@dpdk.org" , Jan Medala , Jakub Palider , Netanel Belgazal , Evgeny Schemeilin , Alejandro Lucero , "Yong Wang" , Andrew Rybchenko , Hemant Agrawal , "Kulasek, TomaszX" Thread-Topic: [dpdk-dev] [PATCH v12 0/6] add Tx preparation Thread-Index: AQHSRbBDKacvBhx2eUCvrHI7LRX1L6DuQp0AgAzj2ACAARFCAIAAISvggAACRICAAAEFEA== Date: Wed, 7 Dec 2016 10:22:35 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772583F0E4E71@irsmsx105.ger.corp.intel.com> References: <1477486575-25148-1-git-send-email-tomaszx.kulasek@intel.com> <1479922585-8640-1-git-send-email-tomaszx.kulasek@intel.com> <8317180.L80Qf11uiu@xps13> <2dfc10d2-bb19-1385-aa01-97e44a3db139@intel.com> <20161207081144.GC31182@yliu-dev.sh.intel.com> <2601191342CEEE43887BDE71AB9772583F0E4E4B@irsmsx105.ger.corp.intel.com> <20161207101833.GL31182@yliu-dev.sh.intel.com> In-Reply-To: <20161207101833.GL31182@yliu-dev.sh.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 10:22:40 -0000 > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Wednesday, December 7, 2016 10:19 AM > To: Ananyev, Konstantin > Cc: Yigit, Ferruh ; Olivier Matz ; Thomas Monjalon ; > dev@dpdk.org; Jan Medala ; Jakub Palider ; Netanel Belgazal ; Evgeny > Schemeilin ; Alejandro Lucero ; Yong Wang ; > Andrew Rybchenko ; Hemant Agrawal ; Kulasek, TomaszX > > Subject: Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation >=20 > On Wed, Dec 07, 2016 at 10:13:14AM +0000, Ananyev, Konstantin wrote: > > > > Hi Yliu, > > > > > > > > On Tue, Dec 06, 2016 at 03:53:42PM +0000, Ferruh Yigit wrote: > > > > > Please, we need a comment for each driver saying > > > > > "it is OK, we do not need any checksum preparation for TSO" > > > > > or > > > > > "yes we have to implement tx_prepare or TSO will not work in this= mode" > > > > > > > > > > > Sorry for late. For virtio, I think it's not a must. The checksum stu= ff > > > has been handled inside the Tx function. However, we may could move i= t > > > to tx_prepare, which would actually recover the performance lost > > > introduced while enabling TSO for the non-TSO case. > > > > > > > So would you like to provide a patch for it, > > Or would you like to keep tx_prepare() for virtio as NOP for now? >=20 > Hi Konstantin, >=20 > I'd keep it as it is for now. It should be a trivial patch after all, tha= t > I could provide it when everything are settled down. Ok, thanks for clarification. Konstantin >=20 > --yliu