From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 996472A66 for ; Wed, 7 Dec 2016 13:49:35 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP; 07 Dec 2016 04:49:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,310,1477983600"; d="scan'208";a="39993762" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga006.fm.intel.com with ESMTP; 07 Dec 2016 04:49:34 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.43]) by IRSMSX154.ger.corp.intel.com ([169.254.12.108]) with mapi id 14.03.0248.002; Wed, 7 Dec 2016 12:49:33 +0000 From: "Ananyev, Konstantin" To: "Kulasek, TomaszX" , "Mcnamara, John" , "Yigit, Ferruh" , "dev@dpdk.org" CC: "olivier.matz@6wind.com" Thread-Topic: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in csum engine Thread-Index: AQHSRbDmwzYi3YCBDEOSX+wq+V+iDaD8ap2AgAANGQCAAAM9gIAACgqw Date: Wed, 7 Dec 2016 12:49:32 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772583F0E4FDB@irsmsx105.ger.corp.intel.com> References: <1477486575-25148-1-git-send-email-tomaszx.kulasek@intel.com> <1479922585-8640-1-git-send-email-tomaszx.kulasek@intel.com> <1479922585-8640-7-git-send-email-tomaszx.kulasek@intel.com> <067ddc1b-5b28-47fe-8947-84a218357488@intel.com> <3042915272161B4EB253DA4D77EB373A14F58E53@IRSMSX102.ger.corp.intel.com> In-Reply-To: <3042915272161B4EB253DA4D77EB373A14F58E53@IRSMSX102.ger.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in csum engine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 12:49:36 -0000 Hi everyone, > -----Original Message----- > From: Kulasek, TomaszX > Sent: Wednesday, December 7, 2016 12:12 PM > To: Mcnamara, John ; Yigit, Ferruh ; dev@dpdk.org > Cc: Ananyev, Konstantin ; olivier.matz@6win= d.com > Subject: RE: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in cs= um engine >=20 > Hi John, >=20 > > -----Original Message----- > > From: Mcnamara, John > > Sent: Wednesday, December 7, 2016 13:01 > > To: Yigit, Ferruh ; Kulasek, TomaszX > > ; dev@dpdk.org > > Cc: Ananyev, Konstantin ; > > olivier.matz@6wind.com > > Subject: RE: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in > > csum engine > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit > > > Sent: Wednesday, December 7, 2016 11:14 AM > > > To: Kulasek, TomaszX ; dev@dpdk.org > > > Cc: Ananyev, Konstantin ; > > > olivier.matz@6wind.com > > > Subject: Re: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation i= n > > > csum engine > > > > > > ... > > > <...> > > > > +cmdline_parse_inst_t cmd_csum_txprep =3D { > > > > + .f =3D cmd_csum_txprep_parsed, > > > > + .data =3D NULL, > > > > + .help_str =3D "enable/disable tx preparation path for csum engine= : " > > > > + "csum txprep on|off", > > > > > > Can you please format help string as: > > > "cmd fixed_string fixed|string|options : Description" > > > see commit 26faac80327f > > > > > > above becomes: > > > "csum txprep on|off: Enable/Disable tx preparation path for csum engi= ne" > > > > > > > > > Also, does this require an update to the testpmd docs? > > > > >=20 > Yes, I think. I will add adequate description to the docs. I suppose if we'll get tx_prepare() addressed on all PMDs DPDK support we can safely remove that command. Konstantin >=20 > Tomasz