DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] mempool: try to get objects from cache when the mempool is single consumer and multiple producer
@ 2017-01-09 10:24 Wenfeng Liu
  2017-01-09 10:36 ` Ananyev, Konstantin
  2017-01-10  7:14 ` [dpdk-dev] [PATCH v2] mempool: don't check mempool flags when cache is enabled Wenfeng Liu
  0 siblings, 2 replies; 8+ messages in thread
From: Wenfeng Liu @ 2017-01-09 10:24 UTC (permalink / raw)
  To: olivier.matz; +Cc: dev

We put objects to cache when the mempool is multiple producer, however the cache will not be used when it is single consumer.
With this patch we can get objects from cache when the single consumer is happen to be one of the producers, and this improves performance.

Signed-off-by: Wenfeng Liu <liuwf@arraynetworks.com.cn>
---
 lib/librte_mempool/rte_mempool.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
index d315d42..4ab5a95 100644
--- a/lib/librte_mempool/rte_mempool.h
+++ b/lib/librte_mempool/rte_mempool.h
@@ -1250,8 +1250,9 @@ __mempool_generic_get(struct rte_mempool *mp, void **obj_table,
 	uint32_t index, len;
 	void **cache_objs;
 
-	/* No cache provided or single consumer */
-	if (unlikely(cache == NULL || flags & MEMPOOL_F_SC_GET ||
+	/* No cache provided or single consumer and single producer */
+	if (unlikely(cache == NULL ||
+		     (flags & MEMPOOL_F_SC_GET) && (flags & MEMPOOL_F_SP_PUT) ||
 		     n >= cache->size))
 		goto ring_dequeue;
 
-- 
2.7.4

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2017-01-13 15:34 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-09 10:24 [dpdk-dev] [PATCH] mempool: try to get objects from cache when the mempool is single consumer and multiple producer Wenfeng Liu
2017-01-09 10:36 ` Ananyev, Konstantin
2017-01-10  7:14 ` [dpdk-dev] [PATCH v2] mempool: don't check mempool flags when cache is enabled Wenfeng Liu
2017-01-10  8:26   ` [dpdk-dev] [PATCH v3] " Wenfeng Liu
2017-01-10 15:14     ` Olivier MATZ
2017-01-11  2:25     ` [dpdk-dev] [PATCH v4] mempool: use cache in single producer or consumer mode Wenfeng Liu
2017-01-13 15:23       ` Olivier Matz
2017-01-13 15:34         ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).