Re: [dpdk-dev] [PATCH] kni: use bulk functions to allocate and free mbufs

["Ananyev, Konstantin" <konstantin.ananyev@intel.com>]

Hi Sergey,

...
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index 4476d75..707c300 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -1261,6 +1261,38 @@ static inline void rte_pktmbuf_free(struct rte_mbuf *m)
>  }
> 
>  /**
> + * Free n packets mbuf back into its original mempool.
> + *
> + * Free each mbuf, and all its segments in case of chained buffers. Each
> + * segment is added back into its original mempool.
> + *
> + * @param mp
> + *   The packets mempool.
> + * @param mbufs
> + *   The packets mbufs array to be freed.
> + * @param n
> + *   Number of packets.
> + */
> +static inline void rte_pktmbuf_free_bulk(struct rte_mempool *mp,
> +		struct rte_mbuf **mbufs, unsigned n)
> +{
> +	struct rte_mbuf *mbuf, *m_next;
> +	unsigned i;
> +	for (i = 0; i < n; ++i) {
> +		mbuf = mbufs[i];
> +		__rte_mbuf_sanity_check(mbuf, 1);
> +
> +		mbuf = mbuf->next;
> +		while (mbuf != NULL) {
> +			m_next = mbuf->next;
> +			rte_pktmbuf_free_seg(mbuf);
> +			mbuf = m_next;
> +		}

I think you forgot to call __rte_pktmbuf_prefree_seg(mbufs[i]); somewhere here.
Konstantin

> +	}
> +	rte_mempool_put_bulk(mp, (void * const *)mbufs, n);
> +}
> +
> +/**
>   * Creates a "clone" of the given packet mbuf.
>   *
>   * Walks through all segments of the given packet mbuf, and for each of them:
> diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
> index d315d42..e612a0a 100644
> --- a/lib/librte_mempool/rte_mempool.h
> +++ b/lib/librte_mempool/rte_mempool.h
> @@ -1497,6 +1497,12 @@ rte_mempool_get(struct rte_mempool *mp, void **obj_p)
>  	return rte_mempool_get_bulk(mp, obj_p, 1);
>  }
> 
> +static inline int __attribute__((always_inline))
> +rte_mempool_get_n(struct rte_mempool *mp, void **obj_p, int n)
> +{
> +	return rte_mempool_get_bulk(mp, obj_p, n);
> +}
> +
>  /**
>   * Return the number of entries in the mempool.
>   *
> --
> 2.7.4