From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id B72061150 for ; Wed, 1 Feb 2017 17:41:03 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Feb 2017 08:41:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,320,1477983600"; d="scan'208";a="1101699770" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga001.fm.intel.com with ESMTP; 01 Feb 2017 08:41:01 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.38]) by IRSMSX153.ger.corp.intel.com ([169.254.9.160]) with mapi id 14.03.0248.002; Wed, 1 Feb 2017 16:41:01 +0000 From: "Ananyev, Konstantin" To: Stephen Hemminger , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 6/7] ixgbe: remove useless return Thread-Index: AQHSatCmPcELqR9TGUe0EPo1JwBkMKFUfh6g Date: Wed, 1 Feb 2017 16:40:59 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772583F10FFC2@irsmsx105.ger.corp.intel.com> References: <20170109233022.31154-1-stephen@networkplumber.org> <20170109233022.31154-7-stephen@networkplumber.org> In-Reply-To: <20170109233022.31154-7-stephen@networkplumber.org> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 6/7] ixgbe: remove useless return X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Feb 2017 16:41:04 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Monday, January 9, 2017 11:30 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH 6/7] ixgbe: remove useless return >=20 > If all goto's lead to a return, then better to get rid of goto. >=20 > Signed-off-by: Stephen Hemminger > --- > drivers/net/ixgbe/ixgbe_82599_bypass.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_82599_bypass.c b/drivers/net/ixgbe/i= xgbe_82599_bypass.c > index de9fa5a7..af55cc0a 100644 > --- a/drivers/net/ixgbe/ixgbe_82599_bypass.c > +++ b/drivers/net/ixgbe/ixgbe_82599_bypass.c > @@ -73,7 +73,7 @@ ixgbe_set_fiber_fixed_speed(struct ixgbe_hw *hw, ixgbe_= link_speed speed) > &eeprom_data); > if (status) { > PMD_DRV_LOG(ERR, "Failed to read Rx Rate Select RS0"); > - goto out; > + return; > } >=20 > eeprom_data =3D (eeprom_data & ~IXGBE_SFF_SOFT_RS_SELECT_MASK) & rs; > @@ -83,7 +83,7 @@ ixgbe_set_fiber_fixed_speed(struct ixgbe_hw *hw, ixgbe_= link_speed speed) > eeprom_data); > if (status) { > PMD_DRV_LOG(ERR, "Failed to write Rx Rate Select RS0"); > - goto out; > + return; > } >=20 > /* Set RS1 */ > @@ -92,7 +92,7 @@ ixgbe_set_fiber_fixed_speed(struct ixgbe_hw *hw, ixgbe_= link_speed speed) > &eeprom_data); > if (status) { > PMD_DRV_LOG(ERR, "Failed to read Rx Rate Select RS1"); > - goto out; > + return; > } >=20 > eeprom_data =3D (eeprom_data & ~IXGBE_SFF_SOFT_RS_SELECT_MASK) & rs; > @@ -102,10 +102,8 @@ ixgbe_set_fiber_fixed_speed(struct ixgbe_hw *hw, ixg= be_link_speed speed) > eeprom_data); > if (status) { > PMD_DRV_LOG(ERR, "Failed to write Rx Rate Select RS1"); > - goto out; > + return; > } > -out: > - return; > } >=20 > /** > -- Acked-by: Konstantin Ananyev > 2.11.0