From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id D039E1150 for ; Wed, 1 Feb 2017 19:10:03 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP; 01 Feb 2017 10:10:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,321,1477983600"; d="scan'208";a="59727896" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga005.jf.intel.com with ESMTP; 01 Feb 2017 10:10:01 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.38]) by IRSMSX107.ger.corp.intel.com ([169.254.10.3]) with mapi id 14.03.0248.002; Wed, 1 Feb 2017 18:10:00 +0000 From: "Ananyev, Konstantin" To: "Yigit, Ferruh" , "Lu, Wenzhuo" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: clean up rte_eth_dev_info_get Thread-Index: AQHSdrRVRl/bTuVA+02KkpIDzfQM9KFUYbeggAAVWYCAAAcVkA== Date: Wed, 1 Feb 2017 18:10:00 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772583F110053@irsmsx105.ger.corp.intel.com> References: <1485311962-62335-1-git-send-email-wenzhuo.lu@intel.com> <2601191342CEEE43887BDE71AB9772583F10FFA1@irsmsx105.ger.corp.intel.com> <410cf75d-0ceb-d372-778f-bfa19392443b@intel.com> In-Reply-To: <410cf75d-0ceb-d372-778f-bfa19392443b@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clean up rte_eth_dev_info_get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Feb 2017 18:10:04 -0000 > -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, February 1, 2017 5:40 PM > To: Ananyev, Konstantin ; Lu, Wenzhuo ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clean up rte_eth_dev_info_get >=20 > On 2/1/2017 4:24 PM, Ananyev, Konstantin wrote: > > Hi Wenzhuo, > > > >> -----Original Message----- > >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > >> Sent: Wednesday, January 25, 2017 2:39 AM > >> To: dev@dpdk.org > >> Cc: Lu, Wenzhuo > >> Subject: [dpdk-dev] [PATCH] net/ixgbe: clean up rte_eth_dev_info_get > >> > >> It'not appropriate to call rte_eth_dev_info_get in PMD, > >> as rte_eth_dev_info_get need to get info from PMD. > >> Remove rte_eth_dev_info_get from PMD code and get the > >> info directly. > >> > >> Signed-off-by: Wenzhuo Lu > >> --- > >> drivers/net/ixgbe/ixgbe_ethdev.c | 144 ++++++++++++++++++------------= --------- > >> 1 file changed, 68 insertions(+), 76 deletions(-) > >> > >> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgb= e_ethdev.c > >> index 64ce55a..f14a68b 100644 > >> --- a/drivers/net/ixgbe/ixgbe_ethdev.c > >> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > >> @@ -4401,17 +4401,17 @@ static int ixgbevf_dev_xstats_get_names(__rte_= unused struct rte_eth_dev *dev, > >> int rar_entry; > >> uint8_t *new_mac =3D (uint8_t *)(mac_addr); > >> struct rte_eth_dev *dev; > >> - struct rte_eth_dev_info dev_info; > >> + struct rte_pci_device *pci_dev; > >> > >> RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); > >> > >> dev =3D &rte_eth_devices[port]; > >> - rte_eth_dev_info_get(port, &dev_info); > >> + pci_dev =3D IXGBE_DEV_TO_PCI(dev); > >> > >> - if (is_ixgbe_pmd(dev_info.driver_name) !=3D 0) > >> + if (is_ixgbe_pmd(dev->data->drv_name)) > >> return -ENOTSUP; > > > > I wonder why do we need now that it is really an ixgbe device all over = the place? >=20 > This device specific API, so it is missing merits of abstraction layer, > application can these APIs with any port_id, API should be protected for = it. Ah ok, my bad - didn't realize from the patch that it affects only device s= pecific API :) Would It be too much hassle to move these functions into a separate file (r= te_ixgbe_pmd.c or so)? Konstantin >=20 > > Konstantin > >