From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 833A62C6B for ; Sun, 5 Feb 2017 12:59:24 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP; 05 Feb 2017 03:59:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,338,1477983600"; d="scan'208";a="1091068805" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga001.jf.intel.com with ESMTP; 05 Feb 2017 03:59:22 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.38]) by IRSMSX103.ger.corp.intel.com ([163.33.3.157]) with mapi id 14.03.0248.002; Sun, 5 Feb 2017 11:59:21 +0000 From: "Ananyev, Konstantin" To: "Wu, Jingjing" , "dev@dpdk.org" Thread-Topic: [PATCH v2 3/5] net/ixgbe: fix bitmask of supported Tx flags Thread-Index: AQHSfpgovt8BW9hQEEeBuuvdmAR/L6FaURNQ Date: Sun, 5 Feb 2017 11:59:21 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772583F110FFC@irsmsx105.ger.corp.intel.com> References: <1485258650-86193-1-git-send-email-jingjing.wu@intel.com> <1486179375-133509-1-git-send-email-jingjing.wu@intel.com> <1486179375-133509-4-git-send-email-jingjing.wu@intel.com> In-Reply-To: <1486179375-133509-4-git-send-email-jingjing.wu@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/5] net/ixgbe: fix bitmask of supported Tx flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Feb 2017 11:59:24 -0000 Hi Jingjing, > -----Original Message----- > From: Wu, Jingjing > Sent: Saturday, February 4, 2017 3:36 AM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Ananyev, Konstantin > Subject: [PATCH v2 3/5] net/ixgbe: fix bitmask of supported Tx flags >=20 > Add missed flags to bitmask of all supported packet Tx flags. >=20 > CC: konstantin.ananyev@intel.com > Fixes: 7829b8d52be0 ("net/ixgbe: add Tx preparation") > Signed-off-by: Jingjing Wu > --- > drivers/net/ixgbe/ixgbe_rxtx.c | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxt= x.c > index 36f1c02..8454581 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > @@ -81,13 +81,28 @@ > #include "ixgbe_rxtx.h" >=20 > /* Bit Mask to indicate what bits required for building TX context */ > +#ifdef RTE_LIBRTE_IEEE1588 > #define IXGBE_TX_OFFLOAD_MASK ( \ > PKT_TX_VLAN_PKT | \ > PKT_TX_IP_CKSUM | \ > + PKT_TX_IPV4 | \ > PKT_TX_L4_MASK | \ > + PKT_TX_IEEE1588_TMST | \ > PKT_TX_TCP_SEG | \ > PKT_TX_MACSEC | \ > - PKT_TX_OUTER_IP_CKSUM) > + PKT_TX_OUTER_IP_CKSUM | \ > + PKT_TX_OUTER_IPV4) > +#else > +#define IXGBE_TX_OFFLOAD_MASK ( \ > + PKT_TX_VLAN_PKT | \ > + PKT_TX_IP_CKSUM | \ > + PKT_TX_IPV4 | \ Wonder why ixgbe doesn't have PKT_TX_IPV6? Konstantin > + PKT_TX_L4_MASK | \ > + PKT_TX_TCP_SEG | \ > + PKT_TX_MACSEC | \ > + PKT_TX_OUTER_IP_CKSUM | \ > + PKT_TX_OUTER_IPV4) > +#endif >=20 > #define IXGBE_TX_OFFLOAD_NOTSUP_MASK \ > (PKT_TX_OFFLOAD_MASK ^ IXGBE_TX_OFFLOAD_MASK) > -- > 2.4.11